Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752195Ab3J0HFR (ORCPT ); Sun, 27 Oct 2013 03:05:17 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:40815 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751195Ab3J0HFO convert rfc822-to-8bit (ORCPT ); Sun, 27 Oct 2013 03:05:14 -0400 Subject: Re: [PATCH 1/3] thermal: bcm281xx: Add Temperature Monitor driver Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Kumar Gala In-Reply-To: <20131026124546.GH29341@beef> Date: Sun, 27 Oct 2013 02:05:10 -0500 Cc: Wendy Ng , Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Eduardo Valentin , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Christian Daudt , Markus Mayer , Tim Kryger Content-Transfer-Encoding: 8BIT Message-Id: References: <1382745629-1123-1-git-send-email-wendy.ng@broadcom.com> <1382745629-1123-2-git-send-email-wendy.ng@broadcom.com> <382461FD-5CB7-461C-A9A7-76D2EF99C769@codeaurora.org> <46DC9641-6D01-4D2F-B5C3-0942B480D6E0@codeaurora.org> <20131026124546.GH29341@beef> To: Matt Porter X-Mailer: Apple Mail (2.1283) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3617 Lines: 93 On Oct 26, 2013, at 7:45 AM, Matt Porter wrote: > On Sat, Oct 26, 2013 at 01:47:40AM -0500, Kumar Gala wrote: >> >> On Oct 26, 2013, at 1:46 AM, Kumar Gala wrote: >> >>> >>> On Oct 25, 2013, at 7:00 PM, Wendy Ng wrote: >>> >>>> This adds the support for Temperature Monitor (TMON) driver for >>>> Broadcom bcm281xx SoCs. This driver plugs into the Thermal Framework. >>>> >>>> Note that this version of the TMON driver does support interrupt-driven >>>> mode -- only polling-mode of the thermal framework can be used. >>>> >>>> Signed-off-by: Wendy Ng >>>> Reviewed-by: Markus Mayer >>>> Reviewed-by: Christian Daudt >>>> Reviewed-by: Matt Porter >>>> Reviewed-by: Tim Kryger >>>> --- >>>> .../bindings/thermal/bcm-kona-thermal.txt | 24 +++ >>>> drivers/thermal/Kconfig | 11 ++ >>>> drivers/thermal/Makefile | 1 + >>>> drivers/thermal/bcm_kona_tmon.c | 173 ++++++++++++++++++++ >>>> 4 files changed, 209 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt >>>> create mode 100644 drivers/thermal/bcm_kona_tmon.c >>>> >>>> diff --git a/Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt b/Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt >>>> new file mode 100644 >>>> index 0000000..225b898 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/thermal/bcm-kona-thermal.txt >>>> @@ -0,0 +1,24 @@ >>>> +* Broadcom Kona TMON bindings >>>> + >>>> +This version is for the Kona family of SoCs. The TMON (Temperature Monitor) >>>> +block in a Kona SoC device is used to measure the chip temperature at constant >>>> +intervals. >>>> +The TMON block asserts an interrupt if temperature exceeds a user programmed >>>> +threshold value. The TMON block would reset the entire device once it >>>> +reaches a critical temperature which is also a programmable setting. >>>> + >>>> +Required properties: >>>> +- compatible : "brcm,bcm11351-tmon", "brcm,kona-tmon" >>>> +- reg : Address range of the thermal register >>>> +- clocks : the clock signal that drives the TMON block >>>> +- interrupts: the interrupt signal associated with the TMON block >>>> + >>>> + >>>> +Example: >>>> + tmon@34008000 { >>>> + compatible = "brcm,bcm11351-tmon", "brcm,kona-tmon"; >>>> + reg = <0x34008000 0x0024>; >>>> + clocks = <&tmon_1m_clk>; >>>> + interrupts = ; >>>> + status = "disabled"; >>> >>> I'd remove the 'status' line from an example. >>> >>>> + }; >>> >>> Ack on the binding (beyond my minor nit pick on the status prop). >>> >>> Acked-by: Kumar Gala >>> >>> - k >> >> >> After looking at your .dts{i} I see you've got a #thermal-sensor-cells prop, where is that documented? > > It's in Eduardo's "device thermal limits represented in device tree > nodes" series. Here's the direct link to the binding post/discussion > https://lkml.org/lkml/2013/9/26/772 > > -Matt Than as you mentioned in another thread, we should have a reference to that binding in this one. - k -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/