Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752030Ab3J0IB4 (ORCPT ); Sun, 27 Oct 2013 04:01:56 -0400 Received: from shrek-wifi.podlesie.net ([93.179.225.50]:45152 "EHLO shrek.podlesie.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751039Ab3J0IBz (ORCPT ); Sun, 27 Oct 2013 04:01:55 -0400 Date: Sun, 27 Oct 2013 09:01:51 +0100 From: Krzysztof Mazur To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Jason Baron Subject: Re: [PATCH] DYNAMIC_DEBUG: use select DEBUG_FS instead of depends on Message-ID: <20131027080151.GA26131@shrek.podlesie.net> References: <1382821093-2484-1-git-send-email-krzysiek@podlesie.net> <20131027033000.GB32210@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131027033000.GB32210@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1185 Lines: 29 On Sat, Oct 26, 2013 at 08:30:00PM -0700, Greg Kroah-Hartman wrote: > On Sat, Oct 26, 2013 at 10:58:13PM +0200, Krzysztof Mazur wrote: > > Depending on options that are configured later makes them hard > > to enable unless the user knows that he must go backwards. > > Really? We've had this for well over 2 years, people are confused about > this? > > Where? The v3.10 is ok - CONFIG_DYNAMIC_DEBUG is after CONFIG_DEBUG_FS. Maybe it's just me, because on my config I have CONFIG_DEBUG_FS=y, and on the system I was testing usbatm I had CONFIG_DEBUG_FS=n. BTW, on x86_64 to disable CONFIG_DEBUG_FS you need to disable CONFIG_AMD_IOMMU_STATS, which is enabled by default in the x86_64_defconfig (I think that CONFIG_AMD_IOMMU_STATS=n it's a better default). If you enable CONFIG_DEBUG_KERNEL you need to disable CONFIG_FTRACE which is enabled by default. So a lot of users will have CONFIG_DEBUG_FS already selected. Thanks, Krzysiek -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/