Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754595Ab3J0UYL (ORCPT ); Sun, 27 Oct 2013 16:24:11 -0400 Received: from mail-vb0-f51.google.com ([209.85.212.51]:58838 "EHLO mail-vb0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752470Ab3J0UYJ (ORCPT ); Sun, 27 Oct 2013 16:24:09 -0400 MIME-Version: 1.0 In-Reply-To: <20131027134607.E1782C4039D@trevor.secretlab.ca> References: <1381869563-16083-1-git-send-email-grant.likely@linaro.org> <1381869563-16083-10-git-send-email-grant.likely@linaro.org> <20131027134607.E1782C4039D@trevor.secretlab.ca> Date: Sun, 27 Oct 2013 15:24:08 -0500 Message-ID: Subject: Re: [RFC 9/9] of/irq: create interrupts-extended property From: Rob Herring To: Grant Likely Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Rob Herring , Mark Rutland , Pawel Moll , Stephen Warren , Ian Campbell , Kumar Gala , Benjamin Herrenschmidt Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1931 Lines: 41 On Sun, Oct 27, 2013 at 8:46 AM, Grant Likely wrote: > On Tue, 15 Oct 2013 21:39:23 +0100, Grant Likely wrote: >> The standard interrupts property in device tree can only handle >> interrupts coming from a single interrupt parent. If a device is wired >> to multiple interrupt controllers, then it needs to be attached to a >> node with an interrupt-map property to demux the interrupt specifiers >> which is confusing. It would be a lot easier if there was a form of the >> interrupts property that allows for a separate interrupt phandle for >> each interrupt specifier. >> >> This patch does exactly that by creating a new interrupts-extended >> property which reuses the phandle+arguments pattern used by GPIOs and >> other core bindings. >> >> Signed-off-by: Grant Likely >> Cc: Rob Herring > > Alright, I want to merge this one. I've got an Ack from Tony, general > agreement from an in person converstaion from Ben (aside from wishing he > could think of a better property name), and various rumblings of > approval from anyone I talked to about it at ksummit. I'd like to have > something more that that to put into the commit text. Please take a look > and let me know if you agree/disagree with this binding. I think it looks fine, but I'll throw out an alternative proposal. Simply allow for interrupt-parent to be an array in equal size to interrupts property. Then it is a minimal change to the existing binding: interrupt-parent = <&intc1>, <&intc2>; interrupts = <5 0>, <6 0>; Of course interrupts-extended is more inline with standard patterns for bindings. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/