Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754164Ab3J0UbI (ORCPT ); Sun, 27 Oct 2013 16:31:08 -0400 Received: from arkanian.console-pimps.org ([212.110.184.194]:56540 "EHLO arkanian.console-pimps.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752195Ab3J0UbF (ORCPT ); Sun, 27 Oct 2013 16:31:05 -0400 Date: Sun, 27 Oct 2013 20:30:58 +0000 From: Matt Fleming To: Borislav Petkov Cc: dyoung@redhat.com, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, x86@kernel.org, mjg59@srcf.ucam.org, hpa@zytor.com, James.Bottomley@HansenPartnership.com, vgoyal@redhat.com, ebiederm@xmission.com, horms@verge.net.au, kexec@lists.fedoraproject.org, kexec@lists.infradead.org Subject: Re: [patch 2/6] x86 efi: reserve boot service fix Message-ID: <20131027203058.GE1982@console-pimps.org> References: <20131027034713.481920209@dhcp-16-126.nay.redhat.com> <20131027035922.924386710@dhcp-16-126.nay.redhat.com> <20131027105009.GA21868@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131027105009.GA21868@pd.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1116 Lines: 28 On Sun, 27 Oct, at 11:50:09AM, Borislav Petkov wrote: > On Sun, Oct 27, 2013 at 11:47:15AM +0800, dyoung@redhat.com wrote: > > Current code check boot service region with kernel text region by: > > start+size >= __pa_symbol(_text) > > The end of the above region should be start + size - 1 instead. > > > > I see this problem in ovmf + Fedora 19 grub boot: > > text start: 1000000 md start: 800000 md size: 800000 > > > > Signed-off-by: Dave Young > > Acked-by: Borislav Petkov > > Btw, Matt, this being a bugfix and all, shouldn't it be tagged for > stable? Well that depends. Dave, am I correct in thinking that you only noticed this bug when writing kexec support? I'm inclined not to bother with a stable tag if no one has ever noticed any fallout from this bug until now. -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/