Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752080Ab3J1E03 (ORCPT ); Mon, 28 Oct 2013 00:26:29 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:56240 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751857Ab3J1E02 (ORCPT ); Mon, 28 Oct 2013 00:26:28 -0400 Date: Mon, 28 Oct 2013 00:26:27 -0400 (EDT) Message-Id: <20131028.002627.2095063739326406659.davem@davemloft.net> To: ben@decadent.org.uk Cc: kevin.curtis@farsite.co.uk, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 2/8] farsync: Fix confusion about DMA address and buffer offset types From: David Miller In-Reply-To: <1382910704.2994.46.camel@deadeye.wl.decadent.org.uk> References: <1382910437.2994.43.camel@deadeye.wl.decadent.org.uk> <1382910704.2994.46.camel@deadeye.wl.decadent.org.uk> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.1 (shards.monkeyblade.net [0.0.0.0]); Sun, 27 Oct 2013 21:26:28 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 556 Lines: 13 From: Ben Hutchings Date: Sun, 27 Oct 2013 21:51:44 +0000 > - dbg(DBG_TX, "In fst_tx_dma %p %p %d\n", skb, mem, len); > + dbg(DBG_TX, "In fst_tx_dma %x %x %d\n", (u32)skb, mem, len); Please use %p for the skb pointer instead of casting it (which btw will introduce a warning on 64-bit). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/