Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755689Ab3J1Gbc (ORCPT ); Mon, 28 Oct 2013 02:31:32 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:58424 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752715Ab3J1Gba convert rfc822-to-8bit (ORCPT ); Mon, 28 Oct 2013 02:31:30 -0400 Subject: Re: [PATCHv6 1/3] Input: twl4030-pwrbutton - add device tree support Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Kumar Gala In-Reply-To: <20131026113138.GA22920@earth.universe> Date: Mon, 28 Oct 2013 01:31:28 -0500 Cc: Dmitry Torokhov , Grant Likely , Rob Herring , Peter Ujfalusi , Sachin Kamat , Florian Vaussard , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: References: <1382626126-12565-1-git-send-email-sre@debian.org> <1382626126-12565-2-git-send-email-sre@debian.org> <20131025221850.GA8657@earth.universe> <085234CB-BD53-4120-AE77-B06FA9314E96@codeaurora.org> <20131026113138.GA22920@earth.universe> To: Sebastian Reichel X-Mailer: Apple Mail (2.1283) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1751 Lines: 57 On Oct 26, 2013, at 6:31 AM, Sebastian Reichel wrote: > On Sat, Oct 26, 2013 at 01:37:57AM -0500, Kumar Gala wrote: >> >> On Oct 25, 2013, at 5:18 PM, Sebastian Reichel wrote: >> >>> On Fri, Oct 25, 2013 at 04:41:20PM -0500, Kumar Gala wrote: >>>> On Oct 24, 2013, at 9:48 AM, Sebastian Reichel wrote: >>>>> +- interrupt: should be one of the following >>>>> + - <8>: For controllers compatible with twl4030 >>>> >>>> Just checking, but the interrupt is always 8 for this device? >>> >>> Yes. It's currently hardcoded in drivers/mfd/twl-core.c. >> >> The fact that is hard coded in the driver does not imply that it >> should be in the device tree binding. Is there an interrupt >> controller as part of the TWL4030? > > Hardware looks like this: > > &twl4030 { > compatible = "ti,twl4030"; > interrupt-controller; > #interrupt-cells = <1>; > > twl_pwrbutton: pwrbutton { > compatible = "ti,twl4030-pwrbutton"; > interrupts = <8>; /* 8th interrupt from the twl4030 */ > }; > }; > > Simplified the initialization of twl4030 stuff works > like this for non DT boot: > > twl4030_init(...) { > init_subdev(...); > init_subdev("twl4030-pwrbutton", ..., irq=8, ...); > init_subdev(...); > }; > > -- Sebastian ok, than other than Grant's comment about merging some of this together with the other twl4030 bindings, ack. - k -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/