Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756855Ab3J1QA6 (ORCPT ); Mon, 28 Oct 2013 12:00:58 -0400 Received: from mail.skyhub.de ([78.46.96.112]:54031 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755395Ab3J1QA4 (ORCPT ); Mon, 28 Oct 2013 12:00:56 -0400 Date: Mon, 28 Oct 2013 17:00:53 +0100 From: Borislav Petkov To: Matt Fleming Cc: X86 ML , LKML , Borislav Petkov , Matthew Garrett , "H. Peter Anvin" , James Bottomley , Vivek Goyal , Dave Young , linux-efi@vger.kernel.org, fwts-devel@lists.ubuntu.com Subject: Re: [PATCH 12/12] EFI: Runtime services virtual mapping Message-ID: <20131028160053.GO4314@pd.tnic> References: <1379602494-26684-1-git-send-email-bp@alien8.de> <20131008164551.GB16793@pd.tnic> <20131008164831.GD16793@pd.tnic> <20131028112246.GK1982@console-pimps.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20131028112246.GK1982@console-pimps.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1009 Lines: 33 On Mon, Oct 28, 2013 at 11:22:46AM +0000, Matt Fleming wrote: > Could you use the efi_enabled() function to test for EFI_OLD_MEMMAP > instead of test_bit()? Sure. > This way we won't exhaust the bitspace quite so soon (since ARM/ARM64 Yeah, very foresightful. > can reuse EFI_ARCH_1 if they need it), plus this memory mapping method > is a very architecture-specific thing and so makes sense to hide it in > the bowels of arch/x86. If it turns out that ARM/ARM64 need the exact > same config option we can delete EFI_ARCH_1 and move EFI_OLD_MEMMAP to > include/linux/efi.h just like in your original patch. > > What do you think? Yep, done and pushed out. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/