Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757006Ab3J1Q2D (ORCPT ); Mon, 28 Oct 2013 12:28:03 -0400 Received: from forward1h.mail.yandex.net ([84.201.187.146]:50036 "EHLO forward1h.mail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756857Ab3J1Q2A (ORCPT ); Mon, 28 Oct 2013 12:28:00 -0400 X-Greylist: delayed 318 seconds by postgrey-1.27 at vger.kernel.org; Mon, 28 Oct 2013 12:28:00 EDT From: Konstantin Tokarev To: Yann Collet , "linux-mtd@lists.infradead.org" , Brent Taylor , Artem Bityutskiy , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" In-Reply-To: <106621382627723@web13g.yandex.ru> References: <55541379679397@web20h.yandex.ru> <237221382623942@web21m.yandex.ru> <106621382627723@web13g.yandex.ru> Subject: Re: lz4hc compression in UBIFS? MIME-Version: 1.0 Message-Id: <3901382977358@web14h.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Mon, 28 Oct 2013 20:22:38 +0400 Content-Transfer-Encoding: 7bit Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 975 Lines: 25 24.10.2013, 19:15, "Konstantin Tokarev" : > Attached patch to crypto API wrapper for lz4hc seems to fix the issue. I can save > and read files on LZ4HC-compressed volume, and I'm running on LZ4HC-compressed rootfs, > flashed from mkfs.ubifs generated image (patch by Elie De Brauwer). My software > works correctly. > > Unfortunately, on my board LZ4HC-compressed UBIFS volume performs noticeable worse > than LZO, while still faster than zlib. I guess the reason is that CPU is no longer a > bottleneck for my system, but NAND speed. > > Thank you all for your help! Can anyone review the correctness of my patch? Looks like API of LZ4 decompressor is used wrong way in crypto API. -- Regards, Konstantin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/