Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932093Ab3J1Q45 (ORCPT ); Mon, 28 Oct 2013 12:56:57 -0400 Received: from mail-ve0-f174.google.com ([209.85.128.174]:35354 "EHLO mail-ve0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756103Ab3J1Q4z convert rfc822-to-8bit (ORCPT ); Mon, 28 Oct 2013 12:56:55 -0400 MIME-Version: 1.0 In-Reply-To: <1382964295.992.122.camel@kjgkr> References: <1382716919-23345-1-git-send-email-huajun.li.lee@gmail.com> <1382716919-23345-6-git-send-email-huajun.li.lee@gmail.com> <1382964295.992.122.camel@kjgkr> Date: Tue, 29 Oct 2013 00:56:55 +0800 Message-ID: Subject: Re: [f2fs-dev 5/5] f2fs: Handle inline data operations From: Huajun Li To: "jaegeuk.kim" Cc: linux-f2fs-devel , linux-fsdevel , linux-kernel , Huajun Li , Haicheng Li , Weihong Xu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1597 Lines: 50 On Mon, Oct 28, 2013 at 8:44 PM, Jaegeuk Kim wrote: > Hi, > > 2013-10-26 (토), 00:01 +0800, Huajun Li: >> From: Huajun Li >> > > [snip] > >> >> @@ -538,7 +553,7 @@ static int f2fs_write_data_page(struct page *page, >> loff_t i_size = i_size_read(inode); >> const pgoff_t end_index = ((unsigned long long) i_size) >> >> PAGE_CACHE_SHIFT; >> - unsigned offset; >> + unsigned offset = 0; >> bool need_balance_fs = false; >> int err = 0; >> >> @@ -572,7 +587,14 @@ write: >> err = do_write_data_page(page); >> } else { >> f2fs_lock_op(sbi); >> - err = do_write_data_page(page); >> + if (test_opt(sbi, INLINE_DATA) && (i_size <= MAX_INLINE_DATA)) { >> + err = f2fs_write_inline_data(inode, page, offset); >> + ClearPageDirty(page); > > Don't need to call ClearPageDirty(page). > Yes. I will remove it in next version, thanks. >> + f2fs_unlock_op(sbi); >> + goto out; >> + } else { >> + err = do_write_data_page(page); >> + } >> f2fs_unlock_op(sbi); >> need_balance_fs = true; >> > -- > Jaegeuk Kim > Samsung > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/