Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757359Ab3J1Rry (ORCPT ); Mon, 28 Oct 2013 13:47:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21702 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756806Ab3J1Rrx (ORCPT ); Mon, 28 Oct 2013 13:47:53 -0400 Message-ID: <1382982462.4097.38.camel@ul30vt.home> Subject: Re: [PATCH 3/4] VFIO: pci: amend vfio-pci for explicit binding via sysfs only From: Alex Williamson To: Kim Phillips Cc: Bhushan Bharat , Wood Scott , Yoder Stuart , christoffer.dall@linaro.org, linux-kernel@vger.kernel.org, a.motakis@virtualopensystems.com, agraf@suse.de, Sethi Varun , peter.maydell@linaro.org, santosh.shukla@linaro.org, kvm@vger.kernel.org, gregkh@linuxfoundation.org Date: Mon, 28 Oct 2013 11:47:42 -0600 In-Reply-To: <1381472840-3470-3-git-send-email-kim.phillips@linaro.org> References: <1381418830.7979.405.camel@snotra.buserror.net> <1381472840-3470-1-git-send-email-kim.phillips@linaro.org> <1381472840-3470-3-git-send-email-kim.phillips@linaro.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1254 Lines: 38 On Fri, 2013-10-11 at 01:27 -0500, Kim Phillips wrote: > Force the vfio-pci driver to only be bound explicitly via sysfs to avoid > conflics with other drivers in the event of a hotplug. We can't break userspace, so we can't disable the current method of binding devices to vfio-pci. We can add a new method and perhaps deprecate the existing mechanism to be removed at some point in the future. Thanks, Alex > Signed-off-by: Kim Phillips > --- > drivers/vfio/pci/vfio_pci.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c > index 6ab71b9..bdd7833 100644 > --- a/drivers/vfio/pci/vfio_pci.c > +++ b/drivers/vfio/pci/vfio_pci.c > @@ -901,6 +901,9 @@ static struct pci_driver vfio_pci_driver = { > .probe = vfio_pci_probe, > .remove = vfio_pci_remove, > .err_handler = &vfio_err_handlers, > + .driver = { > + .sysfs_bind_only = true, > + }, > }; > > static void __exit vfio_pci_cleanup(void) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/