Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757583Ab3J1VVo (ORCPT ); Mon, 28 Oct 2013 17:21:44 -0400 Received: from mail-pb0-f43.google.com ([209.85.160.43]:39573 "EHLO mail-pb0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751475Ab3J1VVn (ORCPT ); Mon, 28 Oct 2013 17:21:43 -0400 Date: Mon, 28 Oct 2013 14:21:40 -0700 From: Kent Overstreet To: Alexander Gordeev Cc: Oleg Nesterov , Jens Axboe , "Nicholas A. Bellinger" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] percpu_ida: Move waking up waiters out of atomic contexts Message-ID: <20131028212140.GG8153@kmo> References: <20131028100522.GC5744@dhcp-26-207.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131028100522.GC5744@dhcp-26-207.brq.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 668 Lines: 14 On Mon, Oct 28, 2013 at 11:05:25AM +0100, Alexander Gordeev wrote: > Currently percpu_ida_free() waikes up waiters always with local > interrupts disabled and sometimes with pool->lock held. Yet, it > does not appear there is any reason why it could not be done out > of these atomic contexts. This should be a noticable performance boost, nested irqsave/restore is painful. Acked-by: Kent Overstreet -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/