Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757903Ab3J1Wux (ORCPT ); Mon, 28 Oct 2013 18:50:53 -0400 Received: from co1ehsobe003.messaging.microsoft.com ([216.32.180.186]:22906 "EHLO co1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757884Ab3J1Wuu convert rfc822-to-8bit (ORCPT ); Mon, 28 Oct 2013 18:50:50 -0400 X-Forefront-Antispam-Report: CIP:149.199.60.83;KIP:(null);UIP:(null);IPV:NLI;H:xsj-gw1;RD:unknown-60-83.xilinx.com;EFVD:NLI X-SpamScore: -1 X-BigFish: VPS-1(zz98dIc89bh1432Izz1f42h208ch1ee6h1de0h1fdah2073h1202h1e76h1d1ah1d2ah1fc6hzz1de098h8275bh1de097hz2fh95h839h93fhd24hf0ah119dh1288h12a5h12a9h12bdh137ah13b6h1441h14ddh1504h1537h153bh162dh1631h1758h18e1h1946h19b5h1b0ah1d0ch1d2eh1d3fh1dfeh1dffh1e1dh1fe8h1ff5h209eh2216h906i1155h192ch) Date: Mon, 28 Oct 2013 15:50:36 -0700 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: Tomasz Figa CC: Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , Russell King , Chris Ball , Michal Simek , Grant Likely , , , , , Subject: Re: [PATCH 1/2] mmc: arasan: Add driver for Arasan SDHCI References: <1381864085-8806-1-git-send-email-soren.brinkmann@xilinx.com> <1587218.cW45zK0ty2@flatron> <1873048.2t2L2zW4W9@flatron> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <1873048.2t2L2zW4W9@flatron> User-Agent: Mutt/1.5.21 (2010-09-15) Message-ID: <9bba3f23-e6b8-4a9a-93ab-4f89f525a4a2@CO1EHSMHS030.ehs.local> Content-Transfer-Encoding: 8BIT X-OriginatorOrg: xilinx.com X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2744 Lines: 64 On Mon, Oct 28, 2013 at 11:19:13PM +0100, Tomasz Figa wrote: > On Monday 28 of October 2013 14:47:38 Sören Brinkmann wrote: > > On Mon, Oct 28, 2013 at 10:16:49PM +0100, Tomasz Figa wrote: > > > Hi Soren, > > > > > > On Tuesday 15 of October 2013 12:08:04 Soren Brinkmann wrote: > > > > Add a driver for Arasan's SDHCI controller core. > > > > > > > > Signed-off-by: Soren Brinkmann > > > > --- > > > > > > > > .../devicetree/bindings/mmc/arasan,sdhci.txt | 23 +++ > > > > MAINTAINERS | 1 + > > > > drivers/mmc/host/Kconfig | 12 ++ > > > > drivers/mmc/host/Makefile | 1 + > > > > drivers/mmc/host/sdhci-of-arasan.c | 224 > > > > > > > > +++++++++++++++++++++ 5 files changed, 261 insertions(+) > > > > > > > > create mode 100644 > > > > > > > > Documentation/devicetree/bindings/mmc/arasan,sdhci.txt create mode > > > > 100644 drivers/mmc/host/sdhci-of-arasan.c > > > > > > > > diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > > > > b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt new file > > > > mode > > > > 100644 > > > > index 000000000000..20f0fc25e270 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > > > > @@ -0,0 +1,23 @@ > > > > +Device Tree Bindings for the Arasan SDCHI Controller > > > > + > > > > + The bindings follow the mmc[1] and the clock bindings[2]. Only > > > > deviations are + documented here. > > > > + > > > > + [1] Documentation/devicetree/bindings/mmc/mmc.txt > > > > + [2] Documentation/devicetree/bindings/clock/clock-bindings.txt > > > > + > > > > > > > +Required Properties: > > > According to the example below, the list of required properties lacks > > > interrupt-related properties. > > > > Well, the interrupt bindings seem to differ between platforms and > > architecture and looking at documentation for other sdhci bindings it > > seemed to be okay to avoid documenting them in this place. > > Sure, but I believe that this controller always has an interrupt signal, > so at least it should be marked that interrupts need to be specified. Okay, I'll add these lines: - interrupts: Interrupt specifier - interrupt-parent: Phandle for the interrupt controller that services interrupts for this device. Sören -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/