Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756777Ab3J2BGJ (ORCPT ); Mon, 28 Oct 2013 21:06:09 -0400 Received: from intranet.asianux.com ([58.214.24.6]:43618 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751756Ab3J2BGH (ORCPT ); Mon, 28 Oct 2013 21:06:07 -0400 X-Spam-Score: -106.8 Message-ID: <526F09B8.9030202@asianux.com> Date: Tue, 29 Oct 2013 09:04:56 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Vineet Gupta CC: Chen Gang , James Hogan , Al Viro , Arnd Bergmann , "linux-kernel@vger.kernel.org" , Linux-Arch , Max Filippov Subject: Re: [PATCH] arch: use ASM_NL instead of ';' for assembler new line character in the macro References: <526E3CE2.2070405@asianux.com> <526E6A92.6090301@synopsys.com> In-Reply-To: <526E6A92.6090301@synopsys.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1749 Lines: 49 On 10/28/2013 09:45 PM, Vineet Gupta wrote: > On 10/28/2013 04:00 PM, Chen Gang wrote: >> For some toolchains, they use another character as newline in a macro >> (e.g. arc uses '`'), so for generic assembly code, need use ASM_NL (a >> macro) instead of ';' for it. >> >> Since "linux/export.h" are mainly used for exporting work, then our fix >> more likely belongs to "linux/linkage.h", and we need add the related >> checking in "linkage.h". >> >> Also need notice 80 columns wrap, and '\t' for each line. >> >> >> Signed-off-by: Chen Gang >> --- >> arch/arc/include/asm/linkage.h | 2 + >> include/asm-generic/vmlinux.lds.h | 350 +++++++++++++++++++------------------ >> include/linux/linkage.h | 19 + > > Like Max said, please drop the linker script bits - they are OK - otherwise ARC > kernel won't have been building at all. > OK, thank you and Max, I will send patch v2 for it. Hmm... after this modification, it passed allmodconfig for x86_64. And for arc, at least, it can build to "mm/" sub-directory (after here, I stopped compiling). > And you also need to fix kernel/modsign_certificate.S as part of same patchset as > that is where the problem started in first place. > Hmm... can that be another patch? For "kernel/modsign_certificate.S", I recommend to expand the macro which will shrink code line, either need not include additional header file, I feel that will be simpler for both code reader and writers. Thanks. -- Chen Gang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/