Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752899Ab3J2IeO (ORCPT ); Tue, 29 Oct 2013 04:34:14 -0400 Received: from top.free-electrons.com ([176.31.233.9]:37508 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752829Ab3J2IeL (ORCPT ); Tue, 29 Oct 2013 04:34:11 -0400 Date: Tue, 29 Oct 2013 05:34:08 -0300 From: Ezequiel Garcia To: Dan Williams Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Thomas Petazzoni , sachin.kamat@linaro.org, Vinod Koul , dmaengine@vger.kernel.org Subject: Re: [PATCH 2/2] dma: mv_xor: Use high_base mmio where appropriate Message-ID: <20131029083407.GA2416@localhost> References: <1383000855-8377-1-git-send-email-ezequiel.garcia@free-electrons.com> <1383000855-8377-2-git-send-email-ezequiel.garcia@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1512 Lines: 36 On Mon, Oct 28, 2013 at 04:47:20PM -0700, Dan Williams wrote: > [ adding dmaengine ] > > On Mon, Oct 28, 2013 at 3:54 PM, Ezequiel Garcia > wrote: > > Despite requesting two memory resources, called 'base' and 'high_base', the > > driver uses explicitly only the former. The latter is being used implicitly > > by addressing at offset +0x200, which in practice accesses high_base. > > > > Instead of relying in such trick, let's define the registers with the > > offset from high_base, and use high_base explicitly where appropriate. > > > > Signed-off-by: Ezequiel Garcia > > --- > > drivers/dma/mv_xor.c | 3 ++- > > drivers/dma/mv_xor.h | 25 +++++++++++++------------ > > 2 files changed, 15 insertions(+), 13 deletions(-) > > Since it's unused I'd prefer a patch that just deletes xor_high_base. > It's wrongly *unused*, the mmio high_base is actually being used implicitly by always addressing at an offset that addresses +200. Deleting high_base would actually make it worse, for that region will no longer be ioremaped. Maybe the commit message is not clear about it? -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/