Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753495Ab3J2Iee (ORCPT ); Tue, 29 Oct 2013 04:34:34 -0400 Received: from mail-ob0-f181.google.com ([209.85.214.181]:60005 "EHLO mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752594Ab3J2Ieb (ORCPT ); Tue, 29 Oct 2013 04:34:31 -0400 MIME-Version: 1.0 In-Reply-To: <526F6A4F.9040507@asianux.com> References: <526E3CE2.2070405@asianux.com> <526F6A4F.9040507@asianux.com> Date: Tue, 29 Oct 2013 12:34:30 +0400 Message-ID: Subject: Re: [PATCH] arch: use ASM_NL instead of ';' for assembler new line character in the macro From: Max Filippov To: Chen Gang Cc: "vgupta@synopsys.com" , James Hogan , Al Viro , Arnd Bergmann , "linux-kernel@vger.kernel.org" , Linux-Arch Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1332 Lines: 35 On Tue, Oct 29, 2013 at 11:57 AM, Chen Gang wrote: > On 10/28/2013 07:18 PM, Max Filippov wrote: >> Hi Chen, >> >> On Mon, Oct 28, 2013 at 2:30 PM, Chen Gang wrote: >>> > For some toolchains, they use another character as newline in a macro >>> > (e.g. arc uses '`'), so for generic assembly code, need use ASM_NL (a >>> > macro) instead of ';' for it. >>> > Since "linux/export.h" are mainly used for exporting work, then our fix >>> > more likely belongs to "linux/linkage.h", and we need add the related >>> > checking in "linkage.h". >>> > >>> > Also need notice 80 columns wrap, and '\t' for each line. >>> > >>> > >>> > Signed-off-by: Chen Gang >>> > --- >>> > arch/arc/include/asm/linkage.h | 2 + >>> > include/asm-generic/vmlinux.lds.h | 350 +++++++++++++++++++------------------ >> Actually vmlinux.lds.h is not an assembly code, but rather a linker script, >> later preprocessed by cpp. >> > > Consult: do xtensa also has its own ASM_NL? It works well with common semicolon. -- Thanks. -- Max -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/