Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752448Ab3J2ItD (ORCPT ); Tue, 29 Oct 2013 04:49:03 -0400 Received: from intranet.asianux.com ([58.214.24.6]:14343 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751408Ab3J2ItA (ORCPT ); Tue, 29 Oct 2013 04:49:00 -0400 X-Spam-Score: -100.7 Message-ID: <526F763B.6020806@asianux.com> Date: Tue, 29 Oct 2013 16:47:55 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Max Filippov CC: "vgupta@synopsys.com" , James Hogan , Al Viro , Arnd Bergmann , "linux-kernel@vger.kernel.org" , Linux-Arch Subject: Re: [PATCH] arch: use ASM_NL instead of ';' for assembler new line character in the macro References: <526E3CE2.2070405@asianux.com> <526F6A4F.9040507@asianux.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1883 Lines: 53 On 10/29/2013 04:34 PM, Max Filippov wrote: > On Tue, Oct 29, 2013 at 11:57 AM, Chen Gang wrote: >> On 10/28/2013 07:18 PM, Max Filippov wrote: >>> Hi Chen, >>> >>> On Mon, Oct 28, 2013 at 2:30 PM, Chen Gang wrote: >>>>> For some toolchains, they use another character as newline in a macro >>>>> (e.g. arc uses '`'), so for generic assembly code, need use ASM_NL (a >>>>> macro) instead of ';' for it. >>>>> Since "linux/export.h" are mainly used for exporting work, then our fix >>>>> more likely belongs to "linux/linkage.h", and we need add the related >>>>> checking in "linkage.h". >>>>> >>>>> Also need notice 80 columns wrap, and '\t' for each line. >>>>> >>>>> >>>>> Signed-off-by: Chen Gang >>>>> --- >>>>> arch/arc/include/asm/linkage.h | 2 + >>>>> include/asm-generic/vmlinux.lds.h | 350 +++++++++++++++++++------------------ >>> Actually vmlinux.lds.h is not an assembly code, but rather a linker script, >>> later preprocessed by cpp. >>> >> >> Consult: do xtensa also has its own ASM_NL? > > It works well with common semicolon. > Thank you for your confirmation. After scan the "arch/" sub-directory, except arc, the cris, c6x, frv, and parisc are also use ';' as comments, I guess they will welcome this patch. And some of another architectures may use '#', '|', '!', '@' or "//" as line comment mark. It seems most of them support ';' as newline in the macro, but it is also necessary to give a check. If this patch is applied, I will/should sync all the related architectures to let ASM_NL consistency. :-) Thanks. -- Chen Gang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/