Date: Tue, 29 Oct 2013 11:25:43 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org, Corey Ashford <cjashfor@linux.vnet.ibm.com>,
        David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@elte.hu>,
        Namhyung Kim <namhyung@kernel.org>, Paul Mackerras <paulus@samba.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Andi Kleen <andi@firstfloor.org>,
        Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 0/4] perf tools: Fix -g option handling
Message-ID: <20131029102543.GA26154@gmail.com>
References: <20131026120336.GA24439@gmail.com>
 <1382797536-32303-1-git-send-email-jolsa@redhat.com>
 <20131026143231.GB1069@krava.brq.redhat.com>
 <20131027065605.GA28433@gmail.com>
 <20131029102137.GC1093@krava.brq.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20131029102137.GC1093@krava.brq.redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1528
Lines: 45


* Jiri Olsa <jolsa@redhat.com> wrote:

> On Sun, Oct 27, 2013 at 07:56:05AM +0100, Ingo Molnar wrote:
> > 
> > * Jiri Olsa <jolsa@redhat.com> wrote:
> > 
> > > On Sat, Oct 26, 2013 at 04:25:32PM +0200, Jiri Olsa wrote:
> > > > hi,
> > > > changing the '-g/-G' options for record/top commands
> > > > to take NO argument and enable unwind method based
> > > > on .perfconfig setup (using FP by default).
> > > > 
> > > > The current -g option parsing moves into the
> > > > '--call-graph' option.
> > > 
> > > forgot to mention branch:
> > > 
> > >   git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
> > >   perf/cc
> > 
> > I tested it - works perfectly now for me:
> > 
> > Acked-and-tested-by: Ingo Molnar <mingo@kernel.org>
> > 
> > You might want to give --call-graph a single letter option name as well, 
> > -g, -G, -c, -C are all taken already, but both -l and -L are still 
> > available - maybe use -L for it?
> 
> ok, I'll addd the -L
> I'll send it with fixies for other comments

Please do it against tip:perf/core aac898548d04 or later (I just 
pushed it out, it might take a few minutes to propagate), the most 
important parts are in perf/urgent already (which is merged into 
aac898548d04), we can do the rest for v3.13 as delta fixlets.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/