Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755682Ab3J2NEY (ORCPT ); Tue, 29 Oct 2013 09:04:24 -0400 Received: from mail-db9lp0251.outbound.messaging.microsoft.com ([213.199.154.251]:1650 "EHLO db9outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754668Ab3J2NEW (ORCPT ); Tue, 29 Oct 2013 09:04:22 -0400 X-Forefront-Antispam-Report: CIP:62.221.5.235;KIP:(null);UIP:(null);IPV:NLI;H:xir-gw1;RD:unknown-62-221-5-235.ipspace.xilinx.com;EFVD:NLI X-SpamScore: 1 X-BigFish: VPS1(zzbb2dI98dI9371I1432I4015Izz1f42h208ch1ee6h1de0h1fdah2073h1202h1e76h1d1ah1d2ah1fc6hzz1de097hz2fh95h839h947hd24hf0ah119dh1288h12a5h12a9h12bdh137ah13b6h1441h1504h1537h153bh162dh1631h1758h18e1h190ch1946h19b4h19b5h19c3h1b0ah1be0h1d0ch1d2eh1d3fh1dfeh1dffh1fe8h1ff5h209eh2216h19b6n1155h192ch) Date: Tue, 29 Oct 2013 14:04:06 +0100 From: Michal Simek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130330 Thunderbird/17.0.5 MIME-Version: 1.0 To: Kumar Gala CC: Tomasz Figa , =?ISO-8859-1?Q?S=F6ren_Brinkma?= =?ISO-8859-1?Q?nn?= , Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , Russell King , Mike Turquette , Michal Simek , , , , Subject: Re: [PATCH v2 1/2] clk/zynq/clkc: Add 'fclk-enable' feature References: <1381425018-5653-1-git-send-email-soren.brinkmann@xilinx.com> <1592656.1ojHcSlzVh@flatron> <2028580.HhySWWnU2A@flatron> <8864256B-F8F9-4474-9B5F-416C3BB96523@codeaurora.org> In-Reply-To: <8864256B-F8F9-4474-9B5F-416C3BB96523@codeaurora.org> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW Message-ID: X-OriginatorOrg: xilinx.com X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1742 Lines: 46 On 10/29/2013 09:26 AM, Kumar Gala wrote: > > On Oct 28, 2013, at 5:17 PM, Tomasz Figa wrote: > >>>>> diff --git a/Documentation/devicetree/bindings/clock/zynq-7000.txt >>>>> b/Documentation/devicetree/bindings/clock/zynq-7000.txt index >>>>> d99af878f5d7..11fdd146ec83 100644 >>>>> --- a/Documentation/devicetree/bindings/clock/zynq-7000.txt >>>>> +++ b/Documentation/devicetree/bindings/clock/zynq-7000.txt >>>>> >>>>> @@ -22,6 +22,10 @@ Required properties: >>>>> Optional properties: >>>>> - clocks : as described in the clock bindings >>>>> - clock-names : as described in the clock bindings >>>>> >>>>> + - fclk-enable : Bit mask to enable FCLKs in cases no proper CCF >>>> >>>> Since it's a vendor specific property, it should include vendor >>>> prefix. >>> >>> The whole driver is vendor specific. Should there really be another >>> prefix for that property? >> >> Yes. If a property is introduced just for use by this particular driver >> then it must be prepended by a vendor prefix. That's a general rule. > > Most all nodes are vendor specific by definition ;). Is this really generic rule? I haven't seen/heard any point regarding this on KS. I don't think we should use prefix here. It is xilinx specific option but there shouldn't be any problem to use fclk-enable without any prefix. Because it means we have to also rename ps-clk-frequency. We are using xlnx prefix for properties which are autogenerated from design tools which is not even this case. Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/