Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755902Ab3J2NIU (ORCPT ); Tue, 29 Oct 2013 09:08:20 -0400 Received: from mail-lb0-f175.google.com ([209.85.217.175]:37148 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755183Ab3J2NIR (ORCPT ); Tue, 29 Oct 2013 09:08:17 -0400 Date: Tue, 29 Oct 2013 14:08:11 +0100 From: Johan Hovold To: Jean-Christophe PLAGNIOL-VILLARD Cc: Johan Hovold , Richard Purdie , Jingoo Han , Nicolas Ferre , Tomi Valkeinen , Andrew Morton , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 2/9] backlight: atmel-pwm-bl: fix gpio polarity in remove Message-ID: <20131029130811.GA29615@localhost> References: <1382522143-32072-1-git-send-email-jhovold@gmail.com> <1382522143-32072-3-git-send-email-jhovold@gmail.com> <20131025110928.GR18477@ns203013.ovh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131025110928.GR18477@ns203013.ovh.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1635 Lines: 44 On Fri, Oct 25, 2013 at 01:09:28PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 11:55 Wed 23 Oct , Johan Hovold wrote: > > Make sure to honour gpio polarity also at remove so that the backlight > > is actually disabled on boards with active-low enable pin. > > > > Cc: stable@vger.kernel.org > > Acked-by: Jingoo Han > > Signed-off-by: Johan Hovold > > --- > > drivers/video/backlight/atmel-pwm-bl.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/video/backlight/atmel-pwm-bl.c b/drivers/video/backlight/atmel-pwm-bl.c > > index 8aac273..3cb0094 100644 > > --- a/drivers/video/backlight/atmel-pwm-bl.c > > +++ b/drivers/video/backlight/atmel-pwm-bl.c > > @@ -205,8 +205,10 @@ static int atmel_pwm_bl_remove(struct platform_device *pdev) > > { > > struct atmel_pwm_bl *pwmbl = platform_get_drvdata(pdev); > > > > - if (pwmbl->gpio_on != -1) > > - gpio_set_value(pwmbl->gpio_on, 0); > > + if (pwmbl->gpio_on != -1) { > here we need to use gpio_is_valid That is a different issue which is fixed by patch 7/9. It doesn't make sense to only change one of the gpio-validity tests. Johan > > + gpio_set_value(pwmbl->gpio_on, > > + 0 ^ pwmbl->pdata->on_active_low); > > + } > > pwm_channel_disable(&pwmbl->pwmc); > > pwm_channel_free(&pwmbl->pwmc); > > > > -- > > 1.8.4 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/