Message-ID: <3DBC6314.6B8AC5EA@mac.com>
Date: Sun, 27 Oct 2002 23:05:08 +0100
From: Peter Waechtler <pwaechtler@mac.com>
MIME-Version: 1.0
To: Manfred Spraul <manfred@colorfullife.com>
CC: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] unified SysV and Posix mqueues as FS
References: <3DBC1A6B.7020108@colorfullife.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1358
Lines: 35

Manfred Spraul schrieb:
> 
>  > - notification not tested
>  > - still linear search in queues
> 
> Is that a problem? Receive does one linear search of the queued
> messages, send does one linear search of the waiting receivers. Both
> lists should be short.
> 

Yes, they _should_ but don't have to be.
It only matters if you ask for specific priority/type of message.

> Could you split your patch into the functional changes and cleanup?
> (const, size_t, you move a few definitions around, whitespace cleanups)
> 
> I don't like the deep integration of the mqueues into the sysv code - is
> that really needed?
> For example, you add the mqueue messages into the sysv array, and then
> add lots of code to separate both again - IPC_RMID cannot remove posix
> queues, etc.
> 
> Have you tried to separate both further? Create a ramfs like filesystem,
> store msg_queue in the inode structure?
> The ids array is only for sysv, only the actual message handling is
> shared between sysv msg and posix mqueues
> 

I plan to separate the interfaces and just share the message stuff.
But time was getting short. :)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/