Message-ID: <1383071755.12439.17.camel@joe-AO722>
Subject: Re: [PATCH 1/2] spi: add Intel Mid SSP driver
From: Joe Perches <joe@perches.com>
To: David Cohen <david.a.cohen@linux.intel.com>
Cc: broonie@kernel.org, ning.li@intel.com, linux-kernel@vger.kernel.org,
        linux-spi@vger.kernel.org, Fei Yang <fei.yang@intel.com>
Date: Tue, 29 Oct 2013 11:35:55 -0700
In-Reply-To: <526FFED4.4070902@linux.intel.com>
References: <1383069950-27754-1-git-send-email-david.a.cohen@linux.intel.com>
	 <1383070766.12439.13.camel@joe-AO722> <526FFED4.4070902@linux.intel.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 911
Lines: 30

On Tue, 2013-10-29 at 11:30 -0700, David Cohen wrote:
> Hi Joe,
> 
> On 10/29/2013 11:19 AM, Joe Perches wrote:
> > On Tue, 2013-10-29 at 11:05 -0700, David Cohen wrote:
> >> This patch adds driver for ssp spi interface on Intel Mid platform.
> >
> > A few simple notes:
> >
> > Please consider using checkpatch.
> 
> I did and got no warnings. But haven't used --strict option.

Interesting.  I thought there was a return (foo);
statement that should have been marked, but I didn't
actually run checkpatch.

static inline u32 is_rx_fifo_empty(struct ssp_drv_context *sspc)
+{
+       return ((read_SSSR(sspc->ioaddr) & SSSR_RNE) == 0);
+}

This could be bool too


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/