Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753533Ab3J3J3l (ORCPT ); Wed, 30 Oct 2013 05:29:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18392 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751730Ab3J3J3j (ORCPT ); Wed, 30 Oct 2013 05:29:39 -0400 Date: Wed, 30 Oct 2013 11:28:48 +0200 From: Gleb Natapov To: Andi Kleen Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen , konrad.wilk@oracle.com, Raghavendra K T Subject: Re: [PATCH 6/7] x86, asmlinkage, xen, kvm: Make {xen,kvm}_lock_spinning global and visible Message-ID: <20131030092848.GD4651@redhat.com> References: <1382458079-24450-1-git-send-email-andi@firstfloor.org> <1382458079-24450-7-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1382458079-24450-7-git-send-email-andi@firstfloor.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1932 Lines: 53 On Tue, Oct 22, 2013 at 09:07:58AM -0700, Andi Kleen wrote: > From: Andi Kleen > > These functions are called from inline assembler stubs, thus > need to be global and visible. > > Cc: konrad.wilk@oracle.com > Cc: gleb@redhat.com > Cc: Raghavendra K T > Signed-off-by: Andi Kleen Acked-by: Gleb Natapov > --- > arch/x86/kernel/kvm.c | 2 +- > arch/x86/xen/spinlock.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c > index a0e2a8a..5d10bb5 100644 > --- a/arch/x86/kernel/kvm.c > +++ b/arch/x86/kernel/kvm.c > @@ -673,7 +673,7 @@ static cpumask_t waiting_cpus; > /* Track spinlock on which a cpu is waiting */ > static DEFINE_PER_CPU(struct kvm_lock_waiting, klock_waiting); > > -static void kvm_lock_spinning(struct arch_spinlock *lock, __ticket_t want) > +__visible void kvm_lock_spinning(struct arch_spinlock *lock, __ticket_t want) > { > struct kvm_lock_waiting *w; > int cpu; > diff --git a/arch/x86/xen/spinlock.c b/arch/x86/xen/spinlock.c > index be6b860..3ab9309 100644 > --- a/arch/x86/xen/spinlock.c > +++ b/arch/x86/xen/spinlock.c > @@ -106,7 +106,7 @@ static DEFINE_PER_CPU(struct xen_lock_waiting, lock_waiting); > static cpumask_t waiting_cpus; > > static bool xen_pvspin = true; > -static void xen_lock_spinning(struct arch_spinlock *lock, __ticket_t want) > +__visible void xen_lock_spinning(struct arch_spinlock *lock, __ticket_t want) > { > int irq = __this_cpu_read(lock_kicker_irq); > struct xen_lock_waiting *w = &__get_cpu_var(lock_waiting); > -- > 1.8.3.1 -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/