Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753485Ab3J3PPh (ORCPT ); Wed, 30 Oct 2013 11:15:37 -0400 Received: from www.linutronix.de ([62.245.132.108]:33472 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753423Ab3J3PPe (ORCPT ); Wed, 30 Oct 2013 11:15:34 -0400 Date: Wed, 30 Oct 2013 16:15:28 +0100 (CET) From: Thomas Gleixner To: Sricharan R cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linus.walleij@linaro.org, linux@arm.linux.org.uk, tony@atomide.com, rnayak@ti.com, marc.zyngier@arm.com, grant.likely@linaro.org, mark.rutland@arm.com, robherring2@gmail.com, santosh.shilimkar@ti.com, Rob Herring Subject: Re: [PATCH V2 1/7] DRIVERS: IRQCHIP: IRQ-GIC: Add support for routable irqs In-Reply-To: <1383145040-15852-2-git-send-email-r.sricharan@ti.com> Message-ID: References: <1383145040-15852-1-git-send-email-r.sricharan@ti.com> <1383145040-15852-2-git-send-email-r.sricharan@ti.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1259 Lines: 42 On Wed, 30 Oct 2013, Sricharan R wrote: > @@ -700,11 +709,22 @@ static int gic_irq_domain_xlate(struct irq_domain *d, > *out_hwirq = intspec[1] + 16; > > /* For SPIs, we need to add 16 more to get the GIC irq ID number */ > - if (!intspec[0]) > + if (!intspec[0]) { > *out_hwirq += 16; Minor nit. This should be in the default implementation. The crossbar implementation will fill out_hwirq in its own way and is not interested in the +16 operation at all. > + ret = gic_routable_irq_domain_ops->xlate(d, controller, > + intspec, > + intsize, > + out_hwirq, > + out_type); > + > + gic->domain = irq_domain_add_legacy(node, gic_irqs, irq_base, > + hwirq_base, &gic_irq_domain_ops, gic); > + } else { > + if (WARN_ON(!gic_routable_irq_domain_ops)) > + return; This warning is pointless, because you have default ops now. > + > + gic->domain = irq_domain_add_linear(node, nr_routable_irqs, > + &gic_irq_domain_ops, > + gic); > } Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/