Date: Wed, 30 Oct 2013 15:25:11 +0000
From: Mel Gorman <mgorman@suse.de>
To: kosaki.motohiro@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org,
        KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [PATCH] Fix page_group_by_mobility_disabled breakage
Message-ID: <20131030152511.GQ2400@suse.de>
References: <1382724575-8450-1-git-send-email-kosaki.motohiro@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1382724575-8450-1-git-send-email-kosaki.motohiro@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1076
Lines: 28

On Fri, Oct 25, 2013 at 02:09:35PM -0400, kosaki.motohiro@gmail.com wrote:
> From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> 
> Currently, set_pageblock_migratetype screw up MIGRATE_CMA and
> MIGRATE_ISOLATE if page_group_by_mobility_disabled is true. It
> rewrite the argument to MIGRATE_UNMOVABLE and we lost these attribute.
> 
> The problem was introduced commit 49255c619f (page allocator: move
> check for disabled anti-fragmentation out of fastpath). So, 4 years
> lived issue may mean that nobody uses page_group_by_mobility_disabled.
> 

Nobody uses page_group_by_mobility_disabled with CMA at least.
page_group_by_mobility_disabled only kicks in automatically for small
machines so it's possible the condition is very rarely encountered.

Anyway

Acked-by: Mel Gorman <mgorman@suse.de>

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/