Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752747Ab3J3QIg (ORCPT ); Wed, 30 Oct 2013 12:08:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7918 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751305Ab3J3QIe (ORCPT ); Wed, 30 Oct 2013 12:08:34 -0400 Message-ID: <52712EE9.9050402@redhat.com> Date: Wed, 30 Oct 2013 17:08:09 +0100 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 MIME-Version: 1.0 To: Greg KH CC: Raghavendra K T , Linus Torvalds , Tim Gardner , Linux Kernel Mailing List , the arch/x86 maintainers , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Gleb Natapov , Marcelo Tosatti , KVM list , Al Viro Subject: Re: [PATCH 3.12-rc7] KVM: Fix modprobe failure for kvm_intel/kvm_amd References: <1383059634-55512-1-git-send-email-tim.gardner@canonical.com> <52700C24.9050001@linux.vnet.ibm.com> <52711121.9030606@linux.vnet.ibm.com> <20131030142359.GA32196@kroah.com> <5271284A.6000002@linux.vnet.ibm.com> <527129D4.3010308@redhat.com> <20131030155930.GA23433@kroah.com> In-Reply-To: <20131030155930.GA23433@kroah.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1262 Lines: 32 Il 30/10/2013 16:59, Greg KH ha scritto: >> > Even if it is okay to exit and not create the files (and I think it's a >> > bit surprising), I'd like at least a printk to signal what's happening. >> > But there should be no reason for debugfs directory creation to fail in >> > the end, except for basic mistakes such as the one that Tim reported, so >> > I think it's better to report the failure. > Creation will "fail" if debugfs is not enabled, so spiting out printk > messages in that case is not a good idea. Interestingly, if debugfs is not enabled we are already returning an error-valued pointer: static inline struct dentry *debugfs_create_dir(const char *name, struct dentry *parent) { return ERR_PTR(-ENODEV); } which would oops a lot of the current callers. Very few places use the currently correct idiom if (IS_ERR(root) || !root) but it's very ugly... Perhaps debugfs_create_dir *should* return an error-valued pointer after all. Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/