Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754034Ab3J3SoQ (ORCPT ); Wed, 30 Oct 2013 14:44:16 -0400 Received: from co9ehsobe003.messaging.microsoft.com ([207.46.163.26]:14666 "EHLO co9outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752189Ab3J3SoM convert rfc822-to-8bit (ORCPT ); Wed, 30 Oct 2013 14:44:12 -0400 X-Forefront-Antispam-Report: CIP:149.199.60.83;KIP:(null);UIP:(null);IPV:NLI;H:xsj-gw1;RD:unknown-60-83.xilinx.com;EFVD:NLI X-SpamScore: -4 X-BigFish: VPS-4(zzbb2dI98dI9371Ic89bh1432I4015Izz1f42h208ch1ee6h1de0h1fdah2073h1202h1e76h1d1ah1d2ah1fc6hzz1de097hz2fh95h839h93fhd24hf0ah119dh1288h12a5h12a9h12bdh137ah13b6h1441h14ddh1504h1537h153bh162dh1631h1758h18e1h1946h19b5h1b0ah1d0ch1d2eh1d3fh1dfeh1dffh1e1dh1fe8h1ff5h209eh2216h906i1155h192ch) Date: Wed, 30 Oct 2013 11:44:03 -0700 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: Michal Simek CC: Kumar Gala , Tomasz Figa , Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , Russell King , Mike Turquette , , , , Subject: Re: [PATCH v2 1/2] clk/zynq/clkc: Add 'fclk-enable' feature References: <1381425018-5653-1-git-send-email-soren.brinkmann@xilinx.com> <1592656.1ojHcSlzVh@flatron> <2028580.HhySWWnU2A@flatron> <8864256B-F8F9-4474-9B5F-416C3BB96523@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-RCIS-Action: ALLOW Message-ID: <229e9b6b-1229-4bc6-bbec-a4395a5b1885@CO9EHSMHS022.ehs.local> Content-Transfer-Encoding: 8BIT X-OriginatorOrg: xilinx.com X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1976 Lines: 50 On Tue, Oct 29, 2013 at 02:04:06PM +0100, Michal Simek wrote: > On 10/29/2013 09:26 AM, Kumar Gala wrote: > > > > On Oct 28, 2013, at 5:17 PM, Tomasz Figa wrote: > > > >>>>> diff --git a/Documentation/devicetree/bindings/clock/zynq-7000.txt > >>>>> b/Documentation/devicetree/bindings/clock/zynq-7000.txt index > >>>>> d99af878f5d7..11fdd146ec83 100644 > >>>>> --- a/Documentation/devicetree/bindings/clock/zynq-7000.txt > >>>>> +++ b/Documentation/devicetree/bindings/clock/zynq-7000.txt > >>>>> > >>>>> @@ -22,6 +22,10 @@ Required properties: > >>>>> Optional properties: > >>>>> - clocks : as described in the clock bindings > >>>>> - clock-names : as described in the clock bindings > >>>>> > >>>>> + - fclk-enable : Bit mask to enable FCLKs in cases no proper CCF > >>>> > >>>> Since it's a vendor specific property, it should include vendor > >>>> prefix. > >>> > >>> The whole driver is vendor specific. Should there really be another > >>> prefix for that property? > >> > >> Yes. If a property is introduced just for use by this particular driver > >> then it must be prepended by a vendor prefix. That's a general rule. > > > > Most all nodes are vendor specific by definition ;). > > Is this really generic rule? I haven't seen/heard any point regarding this on KS. > > I don't think we should use prefix here. It is xilinx specific option > but there shouldn't be any problem to use fclk-enable without any prefix. > Because it means we have to also rename ps-clk-frequency. > > We are using xlnx prefix for properties which are autogenerated from design tools > which is not even this case. So, what is the final call on this? Respin this and changing the prop name, or leaving it as is? Thanks, Sören -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/