Message-ID: <1383162100.9435.39.camel@joe-AO722>
Subject: Re: [PATCH 1/2] tpm/tpm_ppi: Do not compare strcmp(a,b) == -1
From: Joe Perches <joe@perches.com>
To: Peter =?ISO-8859-1?Q?H=FCwe?= <PeterHuewe@gmx.de>
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
        Ashley Lai <ashley@ashleylai.com>, Rajiv Andrade <mail@srajiv.net>,
        Marcel Selhorst <tpmdd@selhorst.net>,
        tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
        Xiaoyan Zhang <xiaoyan.zhang@intel.com>, Gang Wei <gang.wei@intel.com>,
        stable@vger.kernel.org
Date: Wed, 30 Oct 2013 12:41:40 -0700
In-Reply-To: <201310302035.36579.PeterHuewe@gmx.de>
References: <1383093628-31580-1-git-send-email-peterhuewe@gmx.de>
	 <1383095144.12439.41.camel@joe-AO722>
	 <201310302035.36579.PeterHuewe@gmx.de>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1014
Lines: 34

On Wed, 2013-10-30 at 20:35 +0100, Peter H?we wrote:
> Hi Joe, Jason

Hi Peter.

> > lib/string.c:strcmp returns only -1,0,1
> > so that's what the arch versions should do too.
> > However, arch implementations do vary...
[]
> I did not pay attention to where cscope did send me 
> - it was arch/x86/boot/string.c which implements it as 
> 
>         while (*s1 || *s2) {
>                 delta = *s2 - *s1;
>                 if (delta)
>                         return delta;
>                 s1++;
>                 s2++;
>         }
> 
> Although I know that this is not used here, 
> it differs from the version in lib. (Maybe worth changing?)

The arch/... assembly versions don't always
return -1, 0, 1 so I don't think it's worth
it to change all of those.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/