Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755045Ab3J3Tve (ORCPT ); Wed, 30 Oct 2013 15:51:34 -0400 Received: from smtpfb2-g21.free.fr ([212.27.42.10]:48836 "EHLO smtpfb2-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754999Ab3J3Tva (ORCPT ); Wed, 30 Oct 2013 15:51:30 -0400 From: Yann Droneaud To: Al Viro Cc: Yann Droneaud , linux-kernel@vger.kernel.org Subject: [PATCH v4 7/7] file: remove get_unused_fd() macro Date: Wed, 30 Oct 2013 20:47:47 +0100 Message-Id: <2464316e40e4784529f3f80dbc1f4830cdb92ade.1383121137.git.ydroneaud@opteya.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1533 Lines: 40 Macro get_unused_fd() allocates a file descriptor without O_CLOEXEC flag. This can be seen as an unsafe default: in most case O_CLOEXEC must be used to not leak file descriptor across exec(). Using O_CLOEXEC by default allows userspace to choose, without race, if the file descriptor is going to be inherited across exec(), by calling fcntl() when needed. This patch removes get_unused_fd() so that newer kernel code use anon_inode_getfd() or get_unused_fd_flags() with flags provided by userspace. If flags cannot be given by userspace, O_CLOEXEC must be used by default. Signed-off-by: Yann Droneaud Link: http://lkml.kernel.org/r/cover.1383121137.git.ydroneaud@opteya.com --- include/linux/file.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/file.h b/include/linux/file.h index cbacf4f..8666002 100644 --- a/include/linux/file.h +++ b/include/linux/file.h @@ -63,7 +63,6 @@ extern void set_close_on_exec(unsigned int fd, int flag); extern bool get_close_on_exec(unsigned int fd); extern void put_filp(struct file *); extern int get_unused_fd_flags(unsigned flags); -#define get_unused_fd() get_unused_fd_flags(0) extern void put_unused_fd(unsigned int fd); extern void fd_install(unsigned int fd, struct file *file); -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/