Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751728Ab3JaAZA (ORCPT ); Wed, 30 Oct 2013 20:25:00 -0400 Received: from mga03.intel.com ([143.182.124.21]:13398 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750714Ab3JaAY7 convert rfc822-to-8bit (ORCPT ); Wed, 30 Oct 2013 20:24:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.93,535,1378882800"; d="scan'208";a="382527464" From: "Luck, Tony" To: Seiji Aguchi , Madper Xie , "keescook@chromium.org" , "ccross@android.com" , "anton@enomsg.org" CC: "linux-efi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bbboson@gmail.com" Subject: RE: [PATCH 0/2] make all stored entries accessible. Thread-Topic: [PATCH 0/2] make all stored entries accessible. Thread-Index: AQHO1VTFeljrJQot5kSnramJnOjynpoNuMFggAChDwD//5kvUA== Date: Thu, 31 Oct 2013 00:24:56 +0000 Message-ID: <3908561D78D1C84285E8C5FCA982C28F31D52E99@ORSMSX106.amr.corp.intel.com> References: <1383126294-28793-1-git-send-email-cxie@redhat.com> <3908561D78D1C84285E8C5FCA982C28F31D529D7@ORSMSX106.amr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.140] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1064 Lines: 25 > So, do you mean efivars should fix to use the "id" in a proper way? It would avoid the need for all these tests, and additions to the filename to guarantee uniqueness. Not sure what options efivars has to create a unique, persistent "id" for each record. It's a fundamental part of how ERST works (though the unique ID is just based around a timestamp). > I acked Madper's patch 2/2 earlier today, but when I look at your test result, I'm not sure if > it is reasonable for users to make multiple numbers visible to the file name. > >> -r--r--r-- 1 root root 17499 Oct 30 13:41 dmesg-erst-5940651313304961029--2129078373-1383165669 after I added the "count = 0" initialization the filename gets a tiny bit less scary: -r--r--r-- 1 root root 17499 Oct 30 13:41 dmesg-erst-5940651313304961029-0-1383165669 -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/