Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751153Ab3JaAsX (ORCPT ); Wed, 30 Oct 2013 20:48:23 -0400 Received: from intranet.asianux.com ([58.214.24.6]:32974 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750721Ab3JaAsW (ORCPT ); Wed, 30 Oct 2013 20:48:22 -0400 X-Spam-Score: -100.8 Message-ID: <5271A893.4090305@asianux.com> Date: Thu, 31 Oct 2013 08:47:15 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: David Howells CC: Joern Rennecke , James Hogan , Rusty Russell , Takashi Iwai , Vineet Gupta , "jeremy.bennett@embecosm.com" , "linux-kernel@vger.kernel.org" , Claudiu Zissulescu , Francois Bedard , Max Filippov , Al Viro , Arnd Bergmann Subject: Re: [PATCH-next v3] kernel/system_certificate.S: use real contents instead of macro GLOBAL() References: <52705CC0.8020909@asianux.com> <523FD9E7.3050303@asianux.com> <523FDBD7.4040602@asianux.com> <523FE578.5060801@asianux.com> <52672DAC.1030307@asianux.com> <52673E41.6040606@asianux.com> <5267AF98.1010800@asianux.com> <5268B0B1.9050009@asianux.com> <526F1ACE.7080409@asianux.com> <30128.1383137865@warthog.procyon.org.uk> In-Reply-To: <30128.1383137865@warthog.procyon.org.uk> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 899 Lines: 28 On 10/30/2013 08:57 PM, David Howells wrote: > Chen Gang wrote: > >> If a macro is only used within 2 times, and also its contents are >> within 2 lines, recommend to expand it to shrink code line. >> >> For our case, the macro is not portable either: some architectures' >> assembler may use another character to mark newline in a macro (e.g. >> '`' for arc), which will cause issue. >> >> If still want to use macro and let it portable enough, it will also >> need include additional header file (e.g "#include ", >> although it also need be fixed). > > Fine by me. > > Applied. > > Thanks. -- Chen Gang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/