Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752241Ab3JaD4T (ORCPT ); Wed, 30 Oct 2013 23:56:19 -0400 Received: from ozlabs.org ([203.10.76.45]:53525 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751888Ab3JaD4S (ORCPT ); Wed, 30 Oct 2013 23:56:18 -0400 From: Rusty Russell To: Russell King - ARM Linux Cc: Ming Lei , Andrew Morton , Linux Kernel Mailing List , Chen Gang , linux-arm-kernel , Michal Marek Subject: Re: [RFC PATCH] kernel/kallsyms.c: only show legal kernel symbol In-Reply-To: <20131030230920.GQ16735@n2100.arm.linux.org.uk> References: <20131024084559.GD16735@n2100.arm.linux.org.uk> <87mwlyclng.fsf@rustcorp.com.au> <87y55h7vcd.fsf@rustcorp.com.au> <87sivp7eai.fsf@rustcorp.com.au> <874n82gk89.fsf@rustcorp.com.au> <20131028132348.62f7e368@tom-ThinkPad-T410> <87ob6aeyg4.fsf@rustcorp.com.au> <20131030230920.GQ16735@n2100.arm.linux.org.uk> User-Agent: Notmuch/0.15.2 (http://notmuchmail.org) Emacs/23.4.1 (i686-pc-linux-gnu) Date: Thu, 31 Oct 2013 13:44:13 +1030 Message-ID: <87zjpqb08q.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1508 Lines: 39 Russell King - ARM Linux writes: > On Mon, Oct 28, 2013 at 04:20:19PM +1030, Rusty Russell wrote: >> Ming Lei writes: >> > On Mon, 28 Oct 2013 13:44:30 +1030 >> > Rusty Russell wrote: >> > >> >> Ming Lei writes: >> >> >> >> I don't know... It would be your job, as the person making the change, >> >> to find all the users of kallsyms and prove that. >> >> >> >> This is why it is easier not to include incorrect values in the kernel's >> >> kallsyms in the first place. >> > >> > OK, thanks for your comment, and I figured out one way to do it in >> > scripts/kallsyms.c, could you comment on below patch? >> >> Looks great! Seems like we spent more time arguing than it took you to >> code that up. >> >> Acked-by: Rusty Russell >> >> Russell, this seems logical for you to take along with the changes which >> caused the problem? > > The changes are already in mainline since a long time (back in July/August > time). Am I the right person to take stuff for scripts/ ? Isn't that > more kbuild territory? Kallsyms tends to fall between modules and scripts. I assume it's not urgent, so no cc:stable on this one. Applied, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/