Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755154Ab3JaPzG (ORCPT ); Thu, 31 Oct 2013 11:55:06 -0400 Received: from relay1.sgi.com ([192.48.179.29]:53721 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754975Ab3JaPzE (ORCPT ); Thu, 31 Oct 2013 11:55:04 -0400 Date: Thu, 31 Oct 2013 10:55:03 -0500 From: Ben Myers To: Geyslan =?iso-8859-1?Q?Greg=F3rio?= Bem , Eric Sandeen Cc: Alex Elder , open list , XFS FILESYSTEM Subject: Re: [PATCH] xfs: fix possible NULL dereference Message-ID: <20131031155503.GO1935@sgi.com> References: <5265C03B.50701@sandeen.net> <20131022001732.GI4446@dastard> <20131022203946.GB2797@dastard> <5266E4BD.8030601@sandeen.net> <20131022210300.GC2797@dastard> <5266EBF0.901@sandeen.net> <20131023203435.GR1935@sgi.com> <5271672C.7070101@sandeen.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5271672C.7070101@sandeen.net> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 875 Lines: 25 Hey Geyslan, On Wed, Oct 30, 2013 at 03:08:12PM -0500, Eric Sandeen wrote: > On 10/23/13 3:34 PM, Ben Myers wrote: > > > xfs: fix possible NULL dereference in xlog_verify_iclog > > > > In xlog_verify_iclog a debug check of the incore log buffers prints an > > error if icptr is null and then goes on to dereference the pointer > > regardless. Convert this to an assert so that the intention is clear. > > This was reported by Coverty. > > > > Reported-by: Geyslan G. Bem > > Signed-off-by: Ben Myers > > Reviewed-by: Eric Sandeen Applied this. Many thanks! ;) -Ben -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/