Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755444Ab3JaQR5 (ORCPT ); Thu, 31 Oct 2013 12:17:57 -0400 Received: from mail-ie0-f179.google.com ([209.85.223.179]:56436 "EHLO mail-ie0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752916Ab3JaQRy (ORCPT ); Thu, 31 Oct 2013 12:17:54 -0400 MIME-Version: 1.0 In-Reply-To: <20131031104549.GZ18477@ns203013.ovh.net> References: <1380732056-5387-1-git-send-email-dh.herrmann@gmail.com> <20131031104549.GZ18477@ns203013.ovh.net> Date: Thu, 31 Oct 2013 17:17:54 +0100 Message-ID: Subject: Re: [PATCH v2] efifb: prevent null-deref when iterating dmi_list From: David Herrmann To: Jean-Christophe PLAGNIOL-VILLARD Cc: "linux-fbdev@vger.kernel.org" , James Bates , linux-kernel , Tomi Valkeinen , James Bates Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1534 Lines: 37 Hi On Thu, Oct 31, 2013 at 11:45 AM, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 18:40 Wed 02 Oct , David Herrmann wrote: >> The dmi_list array is initialized using gnu designated initializers, and >> therefore may contain fewer explicitly defined entries as there are >> elements in it. This is because the enum above with M_xyz constants >> contains more items than the designated initializer. Those elements not >> explicitly initialized are implicitly set to 0. >> >> Now efifb_setup() loops through all these array elements, and performs >> a strcmp on each item. For non explicitly initialized elements this will >> be a null pointer: >> >> This patch swaps the check order in the if statement, thus checks first >> whether dmi_list[i].base is null. >> >> Signed-off-by: James Bates >> Signed-off-by: David Herrmann > > with the simpleDRM arriving next merge I'm wondering if we need to keep it? SimpleDRM is not coming next merge-window. It's basically finished, but I'm still working on the user-space side as its KMS api is highly reduced compared to fully-featured DRM/KMS drivers. Maybe 3.13 will work out. Anyhow, this patch is still needed as it fixes a serious bug for simplefb. Thanks David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/