Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755666AbaAAULP (ORCPT ); Wed, 1 Jan 2014 15:11:15 -0500 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:59890 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754132AbaAAULL (ORCPT ); Wed, 1 Jan 2014 15:11:11 -0500 Date: Wed, 1 Jan 2014 20:10:53 +0000 From: One Thousand Gnomes To: Joe Xue Cc: "cooloney@gmail.com" , "rpurdie@rpsys.net" , "rob@landley.net" , "milo.kim@ti.com" , "pavel@ucw.cz" , "linux-leds@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" Subject: Re: [PATCH] Add LED pattern trigger Message-ID: <20140101201053.12be7d27@alan.etchedpixels.co.uk> In-Reply-To: References: <1388362275-1618-1-git-send-email-lgxue@hotmail.com> <20131230162158.7420e811@alan.etchedpixels.co.uk> Organization: Intel Corporation X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.20; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1054 Lines: 27 On Tue, 31 Dec 2013 13:48:50 -0500 Joe Xue wrote: > >> + * Based on Richard Purdie's ledtrig-timer.c and Atsushi Nemoto's > >> + * ledtrig-heartbeat.c and Shuah Khan's ledtrig-transient.c > > > > I stil think this belongs in user space except for platforms with hardware > > acceleration for it. > > This can free the user space application from loop or thread. Which is not a good reason for putting it in the kernel. I could make the same argument for putting firefox in the kernel ... > > This doesn't as far as I can see do what you think. If I have the file > > currently open then device_remove_file will not remove my existing access > > to it, but you just released the pattern data so I now write to free > > memory. > > will add the mutex lock to avoid that Ok -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/