Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751508AbaABJAw (ORCPT ); Thu, 2 Jan 2014 04:00:52 -0500 Received: from szxga01-in.huawei.com ([119.145.14.64]:51263 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750733AbaABJAv (ORCPT ); Thu, 2 Jan 2014 04:00:51 -0500 Message-ID: <52C52AAD.8040603@huawei.com> Date: Thu, 2 Jan 2014 17:00:29 +0800 From: Ding Tianhong User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Julia Lawall CC: Joe Perches , Jay Vosburgh , Veaceslav Falico , "David S. Miller" , Netdev , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH RESEND net-next 1/7] bonding: use ether_addr_equal_unaligned for bond addr compare References: <52C4BD16.5010702@huawei.com> <52C52180.2030707@huawei.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.135.72.199] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 866 Lines: 28 On 2014/1/2 16:38, Julia Lawall wrote: > On Thu, 2 Jan 2014, Ding Tianhong wrote: > >> On 2014/1/2 15:39, Julia Lawall wrote: >>> Are the casts needed >> >> >> Yes, otherwise the warming will report: >> >> /net-next/drivers/net/bonding/bond_3ad.c:427: warning: passing argument 1 of ‘ether_addr_equal_64bits’ from incompatible pointer type > > Is it necessary for this driver to use a different type from everyone > else? > > julia > Did you mean the MAC_ADDRESS_EQUAL is excess? I did not remove it because the codes no need to be changed more and it looks that didn't take any negative effect. Regards Ding -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/