Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751162AbaABKi7 (ORCPT ); Thu, 2 Jan 2014 05:38:59 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:65277 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750738AbaABKi6 (ORCPT ); Thu, 2 Jan 2014 05:38:58 -0500 Message-ID: <52C541A9.8060002@huawei.com> Date: Thu, 2 Jan 2014 18:38:33 +0800 From: Ding Tianhong User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Julia Lawall CC: Joe Perches , Jay Vosburgh , Veaceslav Falico , "David S. Miller" , Netdev , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH RESEND net-next 1/7] bonding: use ether_addr_equal_unaligned for bond addr compare References: <52C4BD16.5010702@huawei.com> <52C52180.2030707@huawei.com> <52C52AAD.8040603@huawei.com> <52C53EC6.30902@huawei.com> In-Reply-To: <52C53EC6.30902@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.135.72.199] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1878 Lines: 60 On 2014/1/2 18:26, Ding Tianhong wrote: > On 2014/1/2 17:14, Julia Lawall wrote: >> On Thu, 2 Jan 2014, Ding Tianhong wrote: >> >>> On 2014/1/2 16:38, Julia Lawall wrote: >>>> On Thu, 2 Jan 2014, Ding Tianhong wrote: >>>> >>>>> On 2014/1/2 15:39, Julia Lawall wrote: >>>>>> Are the casts needed >>>>> >>>>> >>>>> Yes, otherwise the warming will report: >>>>> >>>>> /net-next/drivers/net/bonding/bond_3ad.c:427: warning: passing argument 1 of ‘ether_addr_equal_64bits’ from incompatible pointer type >>>> >>>> Is it necessary for this driver to use a different type from everyone >>>> else? >>>> >>>> julia >>>> >>> Did you mean the MAC_ADDRESS_EQUAL is excess? >>> I did not remove it because the codes no need to be changed more and it looks that didn't take any negative effect. >> >> No, I was wondering about the mac_addr type, defined in bond_3ad.h. Other >> code just has the array inlined into the containing structure. >> >> julia >> I reviewed the struct mac_addr again, and feel that even it looks not comfortable, but make the lacp struct more meaning for 3ad, what do you think about it, I think no need to revert them to u8. Regards Ding > > Oh, sorry for mismatch.:) > The code for bond_3ad mode is too old and the use for mac addr is not so comfortable. > > I think I need to send a patch to fix the unusual mac addr and make it more reasonable. > > Thanks for your opinion. > > Regards > Ding > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/