Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751321AbaABKmv (ORCPT ); Thu, 2 Jan 2014 05:42:51 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:14492 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750924AbaABKmu (ORCPT ); Thu, 2 Jan 2014 05:42:50 -0500 X-IronPort-AV: E=Sophos;i="4.95,590,1384297200"; d="scan'208";a="43230103" Date: Thu, 2 Jan 2014 11:42:46 +0100 (CET) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Ding Tianhong cc: Julia Lawall , Joe Perches , Jay Vosburgh , Veaceslav Falico , "David S. Miller" , Netdev , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH RESEND net-next 1/7] bonding: use ether_addr_equal_unaligned for bond addr compare In-Reply-To: <52C541A9.8060002@huawei.com> Message-ID: References: <52C4BD16.5010702@huawei.com> <52C52180.2030707@huawei.com> <52C52AAD.8040603@huawei.com> <52C53EC6.30902@huawei.com> <52C541A9.8060002@huawei.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323328-227853327-1388659368=:2182" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2204 Lines: 59 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-227853327-1388659368=:2182 Content-Type: TEXT/PLAIN; charset=utf-8 Content-Transfer-Encoding: 8BIT On Thu, 2 Jan 2014, Ding Tianhong wrote: > On 2014/1/2 18:26, Ding Tianhong wrote: > > On 2014/1/2 17:14, Julia Lawall wrote: > >> On Thu, 2 Jan 2014, Ding Tianhong wrote: > >> > >>> On 2014/1/2 16:38, Julia Lawall wrote: > >>>> On Thu, 2 Jan 2014, Ding Tianhong wrote: > >>>> > >>>>> On 2014/1/2 15:39, Julia Lawall wrote: > >>>>>> Are the casts needed > >>>>> > >>>>> > >>>>> Yes, otherwise the warming will report: > >>>>> > >>>>> /net-next/drivers/net/bonding/bond_3ad.c:427: warning: passing argument 1 of ‘ether_addr_equal_64bits’ from incompatible pointer type > >>>> > >>>> Is it necessary for this driver to use a different type from everyone > >>>> else? > >>>> > >>>> julia > >>>> > >>> Did you mean the MAC_ADDRESS_EQUAL is excess? > >>> I did not remove it because the codes no need to be changed more and it looks that didn't take any negative effect. > >> > >> No, I was wondering about the mac_addr type, defined in bond_3ad.h. Other > >> code just has the array inlined into the containing structure. > >> > >> julia > >> > > I reviewed the struct mac_addr again, and feel that even it looks not comfortable, but > make the lacp struct more meaning for 3ad, what do you think about it, I think no need > to revert them to u8. Personally, when I see things that are different, I start wondering about why. So if there is no reason for it to be different, I would prefer that it is the same. Certainly, a mac_addr type is more meaningful than just an array with size ETH_ALEN, or worse an array with size 6. But I am not sure that it is practical to introduce that type everywhere. In any case, it is not a big issue. julia --8323328-227853327-1388659368=:2182-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/