Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751172AbaABLIn (ORCPT ); Thu, 2 Jan 2014 06:08:43 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:7651 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750744AbaABLIl (ORCPT ); Thu, 2 Jan 2014 06:08:41 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Thu, 02 Jan 2014 03:09:35 -0800 Message-ID: <52C548B6.60902@nvidia.com> Date: Thu, 2 Jan 2014 19:08:38 +0800 From: bilhuang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Viresh Kumar , Stephen Warren , Rob Herring , Grant Likely CC: "Rafael J. Wysocki" , Thierry Reding , Linux Kernel Mailing List , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-tegra@vger.kernel.org" Subject: Re: [PATCH v5 1/1] cpufreq: tegra: Re-model Tegra20 cpufreq driver References: <1387451926-21373-1-git-send-email-bilhuang@nvidia.com> <52B41B18.30302@nvidia.com> <52B41F1B.3030005@nvidia.com> <52B4707F.4040303@wwwdotorg.org> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1753 Lines: 39 On 12/23/2013 01:06 PM, Viresh Kumar wrote: > Ccc'ing Grant and Rob as well. > > On 20 December 2013 21:59, Stephen Warren wrote: >> No, I definitely don't agree here. The rules for arch/arm64 are: no >> platform-specific code. We should immediately start planning for that. >> If this means renaming the file that creates the virtual device from >> tegra-cpufreq.c to something else, so be it, but we shouldn't go >> backwards and push stuff into the arch directories. > > I don't mind doing this now as well if it is generic enough. I wasn't sure > if you guys wanted to take it on now.. > > @Bill: So, please create a separate commit for creating such file which > would create a virtual device for probing cpufreq drivers with name picked > from root-node. Compilation of such a file should be configurable but if > it is compiled, then it shouldn't cause any problems if that device isn't > used, for multiplatform kernels specially.. > > Probably then you can widen the scope of your patchset by modifying > some of the existing drivers which require a device to get cpufreq > driver probed. Currently they are all making such a device from > their arch/ stuff. Actually, I don't have plan or resource on doing this, would it be better that you help to do that instead? Thanks. > > I am not sure about the location of such file. Should this be placed in DT > code somewhere or kept in cpufreq? Rob/Grant ?? > Do we have consensus on where to create such file? > -- > viresh > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/