Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751528AbaABNxN (ORCPT ); Thu, 2 Jan 2014 08:53:13 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:61328 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750740AbaABNxM (ORCPT ); Thu, 2 Jan 2014 08:53:12 -0500 X-IronPort-AV: E=Sophos;i="4.95,590,1384300800"; d="scan'208";a="87034223" Message-ID: <52C56F43.6030804@citrix.com> Date: Thu, 2 Jan 2014 13:53:07 +0000 From: David Vrabel User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20121215 Iceowl/1.0b1 Icedove/3.0.11 MIME-Version: 1.0 To: Levente Kurusa CC: LKML , Stefano Stabellini , Greg Kroah-Hartman , David Vrabel , , Andrew Morton , Boris Ostrovsky Subject: Re: [Xen-devel] [PATCH 26/38] xen: xenbus: add missing put_device call References: <1387465429-3568-2-git-send-email-levex@linux.com> <1387465429-3568-27-git-send-email-levex@linux.com> In-Reply-To: <1387465429-3568-27-git-send-email-levex@linux.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.2.76] X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1064 Lines: 34 On 19/12/13 15:03, Levente Kurusa wrote: > This is required so that we give up the last reference to the device. > > Signed-off-by: Levente Kurusa > --- > drivers/xen/xenbus/xenbus_probe.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c > index 3c0a74b..4abb9ee 100644 > --- a/drivers/xen/xenbus/xenbus_probe.c > +++ b/drivers/xen/xenbus/xenbus_probe.c > @@ -465,8 +465,10 @@ int xenbus_probe_node(struct xen_bus_type *bus, > > /* Register with generic device framework. */ > err = device_register(&xendev->dev); > - if (err) > + if (err) { > + put_device(&xendev->dev); > goto fail; > + } > > return 0; > fail: There is a kfree(xendev) here so this introduces a double-free. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/