Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753186AbaABV4i (ORCPT ); Thu, 2 Jan 2014 16:56:38 -0500 Received: from smtp.codeaurora.org ([198.145.11.231]:33170 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752499AbaABVxn (ORCPT ); Thu, 2 Jan 2014 16:53:43 -0500 From: Laura Abbott To: Andrew Morton , Kyungmin Park , Dave Hansen , linux-mm@kvack.org, Russell King Cc: linux-kernel@vger.kernel.org, Laura Abbott , linux-arm-kernel@lists.infradead.org, Neeti Desai Subject: [RFC PATCHv3 09/11] arm: mm: Track lowmem in vmalloc Date: Thu, 2 Jan 2014 13:53:27 -0800 Message-Id: <1388699609-18214-10-git-send-email-lauraa@codeaurora.org> X-Mailer: git-send-email 1.7.8.3 In-Reply-To: <1388699609-18214-1-git-send-email-lauraa@codeaurora.org> References: <1388699609-18214-1-git-send-email-lauraa@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 7947 Lines: 258 Rather than always keeping lowmem and vmalloc separate, we can now allow the two to be mixed. This means that all lowmem areas need to be explicitly tracked in vmalloc to avoid over allocating. Additionally, adjust the vmalloc reserve to account for the fact that there may be a hole in the middle consisting of vmalloc. Signed-off-by: Laura Abbott Signed-off-by: Neeti Desai --- arch/arm/Kconfig | 3 + arch/arm/mm/init.c | 104 ++++++++++++++++++++++++++++++++++++---------------- arch/arm/mm/mm.h | 1 + arch/arm/mm/mmu.c | 29 ++++++++++++++ 4 files changed, 105 insertions(+), 32 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index c1f1a7e..fc7aef2 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -277,6 +277,9 @@ config GENERIC_BUG def_bool y depends on BUG +config ARCH_TRACKS_VMALLOC + bool + source "init/Kconfig" source "kernel/Kconfig.freezer" diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c index 1f7b19a..ddfab22 100644 --- a/arch/arm/mm/init.c +++ b/arch/arm/mm/init.c @@ -574,6 +574,46 @@ static void __init free_highpages(void) #endif } +#define MLK(b, t) b, t, ((t) - (b)) >> 10 +#define MLM(b, t) b, t, ((t) - (b)) >> 20 +#define MLK_ROUNDUP(b, t) b, t, DIV_ROUND_UP(((t) - (b)), SZ_1K) + +#ifdef CONFIG_VMALLOC_INTERMIX +void print_vmalloc_lowmem_info(void) +{ + int i; + void *va_start, *va_end; + + printk(KERN_NOTICE + " vmalloc : 0x%08lx - 0x%08lx (%4ld MB)\n", + MLM(VMALLOC_START, VMALLOC_END)); + + for (i = meminfo.nr_banks - 1; i >= 0; i--) { + if (!meminfo.bank[i].highmem) { + va_start = __va(meminfo.bank[i].start); + va_end = __va(meminfo.bank[i].start + + meminfo.bank[i].size); + printk(KERN_NOTICE + " lowmem : 0x%08lx - 0x%08lx (%4ld MB)\n", + MLM((unsigned long)va_start, (unsigned long)va_end)); + } + if (i && ((meminfo.bank[i-1].start + meminfo.bank[i-1].size) != + meminfo.bank[i].start)) { + if (meminfo.bank[i-1].start + meminfo.bank[i-1].size + <= MAX_HOLE_ADDRESS) { + va_start = __va(meminfo.bank[i-1].start + + meminfo.bank[i-1].size); + va_end = __va(meminfo.bank[i].start); + printk(KERN_NOTICE + " vmalloc : 0x%08lx - 0x%08lx (%4ld MB)\n", + MLM((unsigned long)va_start, + (unsigned long)va_end)); + } + } + } +} +#endif + /* * mem_init() marks the free areas in the mem_map and tells us how much * memory is free. This is done after various parts of the system have @@ -602,55 +642,52 @@ void __init mem_init(void) mem_init_print_info(NULL); -#define MLK(b, t) b, t, ((t) - (b)) >> 10 -#define MLM(b, t) b, t, ((t) - (b)) >> 20 -#define MLK_ROUNDUP(b, t) b, t, DIV_ROUND_UP(((t) - (b)), SZ_1K) - printk(KERN_NOTICE "Virtual kernel memory layout:\n" " vector : 0x%08lx - 0x%08lx (%4ld kB)\n" #ifdef CONFIG_HAVE_TCM " DTCM : 0x%08lx - 0x%08lx (%4ld kB)\n" " ITCM : 0x%08lx - 0x%08lx (%4ld kB)\n" #endif - " fixmap : 0x%08lx - 0x%08lx (%4ld kB)\n" - " vmalloc : 0x%08lx - 0x%08lx (%4ld MB)\n" - " lowmem : 0x%08lx - 0x%08lx (%4ld MB)\n" -#ifdef CONFIG_HIGHMEM - " pkmap : 0x%08lx - 0x%08lx (%4ld MB)\n" -#endif -#ifdef CONFIG_MODULES - " modules : 0x%08lx - 0x%08lx (%4ld MB)\n" -#endif - " .text : 0x%p" " - 0x%p" " (%4d kB)\n" - " .init : 0x%p" " - 0x%p" " (%4d kB)\n" - " .data : 0x%p" " - 0x%p" " (%4d kB)\n" - " .bss : 0x%p" " - 0x%p" " (%4d kB)\n", - + " fixmap : 0x%08lx - 0x%08lx (%4ld kB)\n", MLK(UL(CONFIG_VECTORS_BASE), UL(CONFIG_VECTORS_BASE) + (PAGE_SIZE)), #ifdef CONFIG_HAVE_TCM MLK(DTCM_OFFSET, (unsigned long) dtcm_end), MLK(ITCM_OFFSET, (unsigned long) itcm_end), #endif - MLK(FIXADDR_START, FIXADDR_TOP), - MLM(VMALLOC_START, VMALLOC_END), - MLM(PAGE_OFFSET, (unsigned long)high_memory), + MLK(FIXADDR_START, FIXADDR_TOP)); +#ifdef CONFIG_VMALLOC_INTERMIX + print_vmalloc_lowmem_info(); +#else + printk(KERN_NOTICE + " vmalloc : 0x%08lx - 0x%08lx (%4ld MB)\n" + " lowmem : 0x%08lx - 0x%08lx (%4ld MB)\n", + MLM(VMALLOC_START, VMALLOC_END), + MLM(PAGE_OFFSET, (unsigned long)high_memory)); +#endif #ifdef CONFIG_HIGHMEM - MLM(PKMAP_BASE, (PKMAP_BASE) + (LAST_PKMAP) * + printk(KERN_NOTICE + " pkmap : 0x%08lx - 0x%08lx (%4ld MB)\n" +#endif +#ifdef CONFIG_MODULES + " modules : 0x%08lx - 0x%08lx (%4ld MB)\n" +#endif + " .text : 0x%p" " - 0x%p" " (%4d kB)\n" + " .init : 0x%p" " - 0x%p" " (%4d kB)\n" + " .data : 0x%p" " - 0x%p" " (%4d kB)\n" + " .bss : 0x%p" " - 0x%p" " (%4d kB)\n", +#ifdef CONFIG_HIGHMEM + MLM(PKMAP_BASE, (PKMAP_BASE) + (LAST_PKMAP) * (PAGE_SIZE)), #endif #ifdef CONFIG_MODULES - MLM(MODULES_VADDR, MODULES_END), + MLM(MODULES_VADDR, MODULES_END), #endif - MLK_ROUNDUP(_text, _etext), - MLK_ROUNDUP(__init_begin, __init_end), - MLK_ROUNDUP(_sdata, _edata), - MLK_ROUNDUP(__bss_start, __bss_stop)); - -#undef MLK -#undef MLM -#undef MLK_ROUNDUP + MLK_ROUNDUP(_text, _etext), + MLK_ROUNDUP(__init_begin, __init_end), + MLK_ROUNDUP(_sdata, _edata), + MLK_ROUNDUP(__bss_start, __bss_stop)); /* * Check boundaries twice: Some fundamental inconsistencies can @@ -658,7 +695,7 @@ void __init mem_init(void) */ #ifdef CONFIG_MMU BUILD_BUG_ON(TASK_SIZE > MODULES_VADDR); - BUG_ON(TASK_SIZE > MODULES_VADDR); + BUG_ON(TASK_SIZE > MODULES_VADDR); #endif #ifdef CONFIG_HIGHMEM @@ -677,6 +714,9 @@ void __init mem_init(void) } } +#undef MLK +#undef MLM +#undef MLK_ROUNDUP void free_initmem(void) { #ifdef CONFIG_HAVE_TCM diff --git a/arch/arm/mm/mm.h b/arch/arm/mm/mm.h index 6f9d28b..ba825b0 100644 --- a/arch/arm/mm/mm.h +++ b/arch/arm/mm/mm.h @@ -87,6 +87,7 @@ extern unsigned long arm_dma_pfn_limit; #define arm_dma_pfn_limit (~0ul >> PAGE_SHIFT) #endif +#define MAX_HOLE_ADDRESS (PHYS_OFFSET + 0x10000000) extern phys_addr_t arm_lowmem_limit; void __init bootmem_init(void); diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c index 5450b43..55bd742 100644 --- a/arch/arm/mm/mmu.c +++ b/arch/arm/mm/mmu.c @@ -1006,6 +1006,19 @@ void __init sanity_check_meminfo(void) int i, j, highmem = 0; phys_addr_t vmalloc_limit = __pa(vmalloc_min - 1) + 1; +#ifdef CONFIG_ARCH_TRACKS_VMALLOC + unsigned long hole_start; + for (i = 0; i < (meminfo.nr_banks - 1); i++) { + hole_start = meminfo.bank[i].start + meminfo.bank[i].size; + if (hole_start != meminfo.bank[i+1].start) { + if (hole_start <= MAX_HOLE_ADDRESS) { + vmalloc_min = (void *) (vmalloc_min + + (meminfo.bank[i+1].start - hole_start)); + } + } + } +#endif + for (i = 0, j = 0; i < meminfo.nr_banks; i++) { struct membank *bank = &meminfo.bank[j]; phys_addr_t size_limit; @@ -1304,6 +1317,21 @@ static void __init kmap_init(void) #endif } +static void __init reserve_virtual_lowmem(phys_addr_t start, phys_addr_t end) +{ +#ifdef CONFIG_ARCH_TRACKS_VMALLOC + struct vm_struct *vm; + + vm = early_alloc_aligned(sizeof(*vm), __alignof__(*vm)); + vm->addr = (void *)__phys_to_virt(start); + vm->size = end - start; + vm->flags = VM_LOWMEM; + vm->caller = reserve_virtual_lowmem; + vm_area_add_early(vm); + mark_vmalloc_reserved_area(vm->addr, vm->size); +#endif +} + static void __init map_lowmem(void) { struct memblock_region *reg; @@ -1325,6 +1353,7 @@ static void __init map_lowmem(void) map.type = MT_MEMORY; create_mapping(&map); + reserve_virtual_lowmem(start, end); } } -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/