Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750834AbaACFFF (ORCPT ); Fri, 3 Jan 2014 00:05:05 -0500 Received: from mail-oa0-f43.google.com ([209.85.219.43]:58463 "EHLO mail-oa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750717AbaACFFD convert rfc822-to-8bit (ORCPT ); Fri, 3 Jan 2014 00:05:03 -0500 MIME-Version: 1.0 In-Reply-To: References: <1388394595-1347-1-git-send-email-tushar.behera@linaro.org> Date: Fri, 3 Jan 2014 10:35:02 +0530 Message-ID: Subject: Re: [PATCH] leds: s3c24xx: Fix build failure From: Tushar Behera To: Bryan Wu Cc: lkml , Linux LED Subsystem , "rpurdie@rpsys.net" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1058 Lines: 26 On 3 January 2014 04:12, Bryan Wu wrote: > On Mon, Dec 30, 2013 at 1:09 AM, Tushar Behera wrote: >> Fixes following build error. >> drivers/leds/leds-s3c24xx.c: In function ‘s3c24xx_led_probe’: >> drivers/leds/leds-s3c24xx.c:100:2: error: implicit declaration of >> function ‘s3c_gpio_setpull’ [-Werror=implicit-function-declaration] >> > > I don't see any building error with s3c2410_defconfig. Actually this > is included in > arch/arm/mach-s3c24xx/include/mach/gpio.h which is in > arch/arm/include/asm/gpio.h, then > This requires that CONFIG_NEED_MACH_GPIO_H is defined. Following commit has removed this option for s3c24xx platform. c67d0f29262b ("ARM: s3c24xx: get rid of custom "). -- Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/