Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751482AbaACJd4 (ORCPT ); Fri, 3 Jan 2014 04:33:56 -0500 Received: from mail-vc0-f177.google.com ([209.85.220.177]:58586 "EHLO mail-vc0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbaACJdx (ORCPT ); Fri, 3 Jan 2014 04:33:53 -0500 MIME-Version: 1.0 In-Reply-To: References: <1388362275-1618-1-git-send-email-lgxue@hotmail.com> <20131230162158.7420e811@alan.etchedpixels.co.uk> <20140101201053.12be7d27@alan.etchedpixels.co.uk> <20140101230135.48f6f781@alan.etchedpixels.co.uk> Date: Fri, 3 Jan 2014 10:33:51 +0100 Message-ID: Subject: Re: [PATCH] Add LED pattern trigger From: Richard Weinberger To: Bryan Wu Cc: David Lang , One Thousand Gnomes , Joe Xue , "rpurdie@rpsys.net" , "rob@landley.net" , "milo.kim@ti.com" , "pavel@ucw.cz" , "linux-leds@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 730 Lines: 21 On Fri, Jan 3, 2014 at 1:14 AM, Bryan Wu wrote: > IMHO, firstly we should take this trigger into kernel, most time it > works as a module. But we need to define a good interface between > kernel and user space. Put it in first place into the kernel such that it becomes ABI and nobody is allowed to remove it later? Better design a sane interface such that such complex LED operations can be achieved in userspace using an helper library. -- Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/