Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752160AbaACNYn (ORCPT ); Fri, 3 Jan 2014 08:24:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:22661 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751675AbaACNYm (ORCPT ); Fri, 3 Jan 2014 08:24:42 -0500 Date: Fri, 3 Jan 2014 14:24:25 +0100 From: Jiri Olsa To: Namhyung Kim Cc: Steven Rostedt , Arnaldo Carvalho de Melo , Frederic Weisbecker , Peter Zijlstra , Ingo Molnar , Namhyung Kim , LKML Subject: Re: [PATCH 1/4] tools lib traceevent: Add state member to struct trace_seq Message-ID: <20140103132425.GC1190@krava.brq.redhat.com> References: <1387445666-7821-1-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1387445666-7821-1-git-send-email-namhyung@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2189 Lines: 63 On Thu, Dec 19, 2013 at 06:34:23PM +0900, Namhyung Kim wrote: > From: Namhyung Kim > > The trace_seq->state is for tracking errors during the use of > trace_seq APIs and getting rid of die() in it. > > Signed-off-by: Namhyung Kim > --- > tools/lib/traceevent/event-parse.h | 7 +++++++ > tools/lib/traceevent/trace-seq.c | 41 ++++++++++++++++++++++++++++++++++---- > 2 files changed, 44 insertions(+), 4 deletions(-) > > diff --git a/tools/lib/traceevent/event-parse.h b/tools/lib/traceevent/event-parse.h > index cf5db9013f2c..3c890cb28db7 100644 > --- a/tools/lib/traceevent/event-parse.h > +++ b/tools/lib/traceevent/event-parse.h > @@ -58,6 +58,12 @@ struct pevent_record { > #endif > }; > > +enum trace_seq_fail { > + TRACE_SEQ__GOOD, > + TRACE_SEQ__BUFFER_POISONED, > + TRACE_SEQ__MEM_ALLOC_FAILED, > +}; > + > /* > * Trace sequences are used to allow a function to call several other functions > * to create a string of data to use (up to a max of PAGE_SIZE). > @@ -68,6 +74,7 @@ struct trace_seq { > unsigned int buffer_size; > unsigned int len; > unsigned int readpos; > + enum trace_seq_fail state; > }; > > void trace_seq_init(struct trace_seq *s); > diff --git a/tools/lib/traceevent/trace-seq.c b/tools/lib/traceevent/trace-seq.c > index d7f2e68bc5b9..976ad2a146b3 100644 > --- a/tools/lib/traceevent/trace-seq.c > +++ b/tools/lib/traceevent/trace-seq.c > @@ -32,8 +32,8 @@ > #define TRACE_SEQ_POISON ((void *)0xdeadbeef) > #define TRACE_SEQ_CHECK(s) \ > do { \ > - if ((s)->buffer == TRACE_SEQ_POISON) \ > - die("Usage of trace_seq after it was destroyed"); \ > + if ((s)->buffer == TRACE_SEQ_POISON) \ > + (s)->state = TRACE_SEQ__BUFFER_POISONED; \ So unless we use trace_seq_do_printf we dont have any notification that this went wrong..? How about use some sort of WARN_ONCE any time the state is set != GOOD ? thanks, jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/