Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753773AbaACWQV (ORCPT ); Fri, 3 Jan 2014 17:16:21 -0500 Received: from mail-ig0-f179.google.com ([209.85.213.179]:50903 "EHLO mail-ig0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753313AbaACWQT (ORCPT ); Fri, 3 Jan 2014 17:16:19 -0500 MIME-Version: 1.0 In-Reply-To: References: <1388234173-31654-1-git-send-email-jeffrey.t.kirsher@intel.com> <20140102.192133.1585340046080167370.davem@davemloft.net> From: Bjorn Helgaas Date: Fri, 3 Jan 2014 15:15:57 -0700 Message-ID: Subject: Re: [net-next] pci_regs.h: Add PCI bus link speed and width defines To: Jesse Brandeburg Cc: David Miller , "linux-pci@vger.kernel.org" , Jeff Kirsher , NetDEV list , "gospo@redhat.com" , "sassmann@redhat.com" , "linux-kernel@vger.kernel.org" , Bjorn Helgaas Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2924 Lines: 65 On Fri, Jan 3, 2014 at 2:53 PM, Jesse Brandeburg wrote: > +linux-pci Thanks, Jesse. > > > On Thu, Jan 2, 2014 at 4:21 PM, David Miller wrote: >> From: Jeff Kirsher >> Date: Sat, 28 Dec 2013 04:36:13 -0800 >> >>> Add missing PCI bus link speed 8.0 GT/s and bus link widths of >>> x1, x2, x4 and x8. >>> >>> CC: >>> Signed-off-by: Jeff Kirsher >> >> Can a PCI person please ACK this? This is a prerequisite for some >> networking driver changes Jeff would like to push to me. The additions look correct to me, and I don't object to them per se, so: Acked-by: Bjorn Helgaas However, I do raise my eyebrows a bit at drivers that poke around in the PCIe capability. I would prefer to have PCI core interfaces that handle that instead. But I haven't seen Jeff's changes yet. >>> --- >>> include/uapi/linux/pci_regs.h | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h >>> index 4a98e85..c870c2a 100644 >>> --- a/include/uapi/linux/pci_regs.h >>> +++ b/include/uapi/linux/pci_regs.h >>> @@ -489,7 +489,12 @@ >>> #define PCI_EXP_LNKSTA_CLS 0x000f /* Current Link Speed */ >>> #define PCI_EXP_LNKSTA_CLS_2_5GB 0x0001 /* Current Link Speed 2.5GT/s */ >>> #define PCI_EXP_LNKSTA_CLS_5_0GB 0x0002 /* Current Link Speed 5.0GT/s */ >>> +#define PCI_EXP_LNKSTA_CLS_8_0GB 0x0003 /* Current Link Speed 8.0GT/s */ >>> #define PCI_EXP_LNKSTA_NLW 0x03f0 /* Negotiated Link Width */ >>> +#define PCI_EXP_LNKSTA_NLW_X1 0x0010 /* Current Link Width x1 */ >>> +#define PCI_EXP_LNKSTA_NLW_X2 0x0020 /* Current Link Width x2 */ >>> +#define PCI_EXP_LNKSTA_NLW_X4 0x0040 /* Current Link Width x4 */ >>> +#define PCI_EXP_LNKSTA_NLW_X8 0x0080 /* Current Link Width x8 */ >>> #define PCI_EXP_LNKSTA_NLW_SHIFT 4 /* start of NLW mask in link status */ >>> #define PCI_EXP_LNKSTA_LT 0x0800 /* Link Training */ >>> #define PCI_EXP_LNKSTA_SLC 0x1000 /* Slot Clock Configuration */ > > also note that these defines from this patch are already partially > defined in drivers/pci/probe.c but likely need to move into a header > file and be consolidated throughout the kernel. That said I don't see > any issue with adding these as a separate set of defines in > uapi/linux/pci_regs.h > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/