Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754182AbaACX4E (ORCPT ); Fri, 3 Jan 2014 18:56:04 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:51707 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753834AbaACX4C (ORCPT ); Fri, 3 Jan 2014 18:56:02 -0500 Date: Fri, 3 Jan 2014 15:56:00 -0800 From: Andrew Morton To: Vlastimil Babka Cc: Linus Torvalds , Sasha Levin , Wanpeng Li , Michel Lespinasse , Bob Liu , Nick Piggin , KOSAKI Motohiro , Rik van Riel , David Rientjes , Mel Gorman , Minchan Kim , Hugh Dickins , Johannes Weiner , linux-mm , Linux Kernel Mailing List Subject: Re: [PATCH] mm/mlock: fix BUG_ON unlocked page for nolinear VMAs Message-Id: <20140103155600.ce7194bb8b33d5581b05a162@linux-foundation.org> In-Reply-To: <52C74972.6050909@suse.cz> References: <1387267550-8689-1-git-send-email-liwanp@linux.vnet.ibm.com> <52b1138b.0201430a.19a8.605dSMTPIN_ADDED_BROKEN@mx.google.com> <52B11765.8030005@oracle.com> <52b120a5.a3b2440a.3acf.ffffd7c3SMTPIN_ADDED_BROKEN@mx.google.com> <52B166CF.6080300@suse.cz> <52b1699f.87293c0a.75d1.34d3SMTPIN_ADDED_BROKEN@mx.google.com> <20131218134316.977d5049209d9278e1dad225@linux-foundation.org> <52C71ACC.20603@oracle.com> <52C74972.6050909@suse.cz> X-Mailer: Sylpheed 3.2.0beta5 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1216 Lines: 31 On Sat, 04 Jan 2014 00:36:18 +0100 Vlastimil Babka wrote: > On 01/03/2014 09:52 PM, Linus Torvalds wrote: > > On Fri, Jan 3, 2014 at 12:17 PM, Sasha Levin wrote: > >> > >> Ping? This BUG() is triggerable in 3.13-rc6 right now. > > > > So Andrew suggested just removing the BUG_ON(), but it's been there > > for a *long* time. > > Yes, Andrew also merged this patch for that: > http://ozlabs.org/~akpm/mmots/broken-out/mm-remove-bug_on-from-mlock_vma_page.patch > > But there wasn't enough confidence in the fix to sent it to you yet, I guess. > > The related thread: http://www.spinics.net/lists/linux-mm/msg66972.html Yes, I'd taken the cowardly approach of scheduling it for 3.14, with a 3.13.x backport. Nobody answered my question! Is this a new bug or is it a five-year-old bug which we only just discovered? I guess it doesn't matter much - we should fix it in 3.13. I'll include it in the next for-3.13 batch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/