Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754258AbaADABH (ORCPT ); Fri, 3 Jan 2014 19:01:07 -0500 Received: from mail-ig0-f174.google.com ([209.85.213.174]:38162 "EHLO mail-ig0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753866AbaADABF (ORCPT ); Fri, 3 Jan 2014 19:01:05 -0500 MIME-Version: 1.0 In-Reply-To: <20140103.185607.1380379872647540168.davem@davemloft.net> References: <20140102.192133.1585340046080167370.davem@davemloft.net> <20140103.185607.1380379872647540168.davem@davemloft.net> From: Bjorn Helgaas Date: Fri, 3 Jan 2014 17:00:42 -0700 Message-ID: Subject: Re: [net-next] pci_regs.h: Add PCI bus link speed and width defines To: David Miller Cc: jesse.brandeburg@gmail.com, "linux-pci@vger.kernel.org" , "Kirsher, Jeffrey T" , netdev , "gospo@redhat.com" , "sassmann@redhat.com" , "linux-kernel@vger.kernel.org" , bjorn.helgaas@hp.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 970 Lines: 23 On Fri, Jan 3, 2014 at 4:56 PM, David Miller wrote: > From: Bjorn Helgaas > Date: Fri, 3 Jan 2014 15:15:57 -0700 > >> However, I do raise my eyebrows a bit at drivers that poke around in >> the PCIe capability. I would prefer to have PCI core interfaces that >> handle that instead. But I haven't seen Jeff's changes yet. > > The changes just read the link status to interpret the speed at which > the PCI-E link is running at. Several drivers want to do that. It'd be nice if somebody abstracted that out somehow. Jacob added pcie_get_minimum_link() which is similar. But maybe Jeff needs something more in this case. In any case, it's not a blocker for this patch. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/