Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754589AbaADBiE (ORCPT ); Fri, 3 Jan 2014 20:38:04 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:35663 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754235AbaADBiC (ORCPT ); Fri, 3 Jan 2014 20:38:02 -0500 Date: Fri, 03 Jan 2014 20:37:59 -0500 (EST) Message-Id: <20140103.203759.2168117129392277198.davem@davemloft.net> To: hayeswang@realtek.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH net-next] r8152: fix the wrong return value From: David Miller In-Reply-To: <1388719316-5702-1-git-send-email-hayeswang@realtek.com> References: <1388719316-5702-1-git-send-email-hayeswang@realtek.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.1 (shards.monkeyblade.net [0.0.0.0]); Fri, 03 Jan 2014 17:38:01 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 655 Lines: 16 From: Hayes Wang Date: Fri, 3 Jan 2014 11:21:56 +0800 > The return value should be the boolean value, not the error code. > > Signed-off-by: Hayes Wang > Spotted-by: Dan Carpenter Applied, but I agree with others that it's more canonical to have the function return either an error code, or zero for success, rather than a boolean. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/