Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753322AbaADIgL (ORCPT ); Sat, 4 Jan 2014 03:36:11 -0500 Received: from mail-ee0-f52.google.com ([74.125.83.52]:40216 "EHLO mail-ee0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751015AbaADIgI (ORCPT ); Sat, 4 Jan 2014 03:36:08 -0500 Message-ID: <52C7C7EE.1070407@redhat.com> Date: Sat, 04 Jan 2014 09:35:58 +0100 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 MIME-Version: 1.0 To: "Rafael J. Wysocki" CC: Gleb Natapov , Dirk Brandewie , Kashyap Chamarthy , Josh Boyer , One Thousand Gnomes , Viresh Kumar , "cpufreq@vger.kernel.org" , Linux PM list , "Linux-Kernel@Vger. Kernel. Org" , "Richard W.M. Jones" Subject: Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad References: <52C6F3B4.3050904@gmail.com> <20140103180435.GK10961@minantech.com> <2513222.AheLcigoE8@vostro.rjw.lan> In-Reply-To: <2513222.AheLcigoE8@vostro.rjw.lan> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 705 Lines: 16 Il 03/01/2014 23:46, Rafael J. Wysocki ha scritto: > Well, fixing the KVM bug is surely welcome. > > That said, adding checks to ensure that your assumptions are valid is rarely > wrong, especially if they are done once per kernel boot. And the kernel only > should panic if it cannot continue to run, which isn't the case here. I agree, but I suspect even your check is already late. Your patch is welcome but perhaps it should have a WARN_ON too. Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/