From: hayeswang <hayeswang@realtek.com>
To: "'David Miller'" <davem@davemloft.net>
CC: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-usb@vger.kernel.org>
References: <1388719316-5702-1-git-send-email-hayeswang@realtek.com> <20140103.203759.2168117129392277198.davem@davemloft.net>
Subject: RE: [PATCH net-next] r8152: fix the wrong return value
Date: Mon, 6 Jan 2014 11:20:43 +0800
Message-ID: <85A9FCBA3D724C2FA135DD70BCF1FF4F@realtek.com.tw>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Thread-Index: Ac8I7Z2fop0Io8tOSw6SNMo0FtX/WgBoIY8g
In-Reply-To: <20140103.203759.2168117129392277198.davem@davemloft.net>
Sender: linux-kernel-owner@vger.kernel.org

 David Miller [mailto:davem@davemloft.net] 
> Sent: Saturday, January 04, 2014 9:38 AM
> To: Hayeswang
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; 
> linux-usb@vger.kernel.org
> Subject: Re: [PATCH net-next] r8152: fix the wrong return value
> 
> From: Hayes Wang <hayeswang@realtek.com>
> Date: Fri, 3 Jan 2014 11:21:56 +0800
> 
> > The return value should be the boolean value, not the error code.
> > 
> > Signed-off-by: Hayes Wang <hayeswang@realtek.com>
> > Spotted-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Applied, but I agree with others that it's more canonical to have the
> function return either an error code, or zero for success, rather than
> a boolean.

Thanks. I would find if there is suitable error code.
 
Best Regards,
Hayes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/