Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756562AbaAFWKq (ORCPT ); Mon, 6 Jan 2014 17:10:46 -0500 Received: from mail-pd0-f172.google.com ([209.85.192.172]:53894 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756530AbaAFWKl (ORCPT ); Mon, 6 Jan 2014 17:10:41 -0500 Date: Mon, 6 Jan 2014 14:10:36 -0800 From: Kent Overstreet To: Muthu Kumar , Chris Mason Cc: fengguang.wu@intel.com, Jens Axboe , linux-btrfs , linux-fsdevel , LKML , lkp@linux.intel.com Subject: Re: [block:for-3.14/core] kernel BUG at fs/bio.c:1748 Message-ID: <20140106221036.GE9037@kmo> References: <20140102053101.GA29352@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Chris, the patch below seems to be incorrect - with it we get hangs, so bi_remaining (probably) isn't getting decremented when it should be. You sent Jens fixes for btrfs which I somehow lost when I rebased, do you remember how this is supposed to work? Looking at the code I'm not quite sure what's going on here. On Fri, Jan 03, 2014 at 11:51:31AM -0800, Muthu Kumar wrote: > Looks like Kent missed the btrfs endio in the original commit. How > about this patch: > > --------- > > In btrfs_end_bio, call bio_endio_nodec on the restored bio so the > bi_remaining is accounted for correctly. > > Reported-by: fengguang.wu@intel.com > Cc: Kent Overstreet > CC: Jens Axboe > Signed-off-by: Muthukumar Ratty > -------- > > fs/btrfs/volumes.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c > index f2130de..edfed52 100644 > --- a/fs/btrfs/volumes.c > +++ b/fs/btrfs/volumes.c > @@ -5316,7 +5316,11 @@ static void btrfs_end_bio(struct bio *bio, int err) > } > kfree(bbio); > > - bio_endio(bio, err); > + /* > + * Call endio_nodec on the restored bio so the bi_remaining is > + * accounted for correctly > + */ > + bio_endio_nodec(bio, err); > } else if (!is_orig_bio) { > bio_put(bio); > } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/